-
Notifications
You must be signed in to change notification settings - Fork 349
Update ADK doc according to issue #744 - 6 #757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
```java | ||
--8<-- "examples/java/snippets/src/main/java/tools/GoogleSearchAgentApp.java:full_code" | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BREAKING CHANGE: removal of code samples
```java | ||
--8<-- "examples/java/snippets/src/main/java/tools/CodeExecutionAgentApp.java:full_code" | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BREAKING CHANGE: removal of code samples
) | ||
``` | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BREAKING CHANGE: removal of code samples
```py | ||
--8<-- "examples/python/snippets/tools/built-in-tools/vertexai_rag_engine.py" | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BREAKING CHANGE: removal of code samples
```py | ||
--8<-- "examples/python/snippets/tools/built-in-tools/vertexai_search.py" | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BREAKING CHANGE: removal of code samples
--8<-- "examples/python/snippets/tools/built-in-tools/bigtable.py" | ||
``` | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BREAKING CHANGE: removal of code samples
} | ||
``` | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BREAKING CHANGE: removal of code samples
``` | ||
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BREAKING CHANGE: removal of code samples
|
||
For example, the following approach that uses built-in tools within sub-agents | ||
is **not** currently supported: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BREAKING CHANGE: removal of code samples
``` | ||
|
||
### Customizable Template and Parameterized SQL | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
USABLE with close review and updates (new CL)
* **`list_table_ids`**: Fetches table ids present in a BigQuery dataset. | ||
* **`get_table_info`**: Fetches metadata about a BigQuery table. | ||
* **`execute_sql`**: Runs a SQL query in BigQuery and fetch the result. | ||
* **`execute_sql`**: Runs a SQL query in BigQuery and fetch the result. This tool now includes a `dry_run` parameter. If set to `True`, the query will be validated by BigQuery but not actually executed, returning information about the query's validity and potential cost. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
INCORRECT SUGGESTION: update does not match content of suggestion #6 (Spanner template and Parameterized SQL)
* **`execute_sql`**: Runs a SQL query in BigQuery and fetch the result. This tool now includes a `dry_run` parameter. If set to `True`, the query will be validated by BigQuery but not actually executed, returning information about the query's validity and potential cost. | ||
* **`forecast`**: Runs a BigQuery AI time series forecast using the `AI.FORECAST` function. | ||
* **`ask_data_insights`**: Answers questions about data in BigQuery tables using natural language. | ||
* **`analyze_contribution`**: Runs a BigQuery ML contribution analysis using `ML.CREATE_MODEL` and `ML.GET_INSIGHTS` to identify the dimensions that contribute most significantly to a given metric. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
INCORRECT SUGGESTION: update does not match content of suggestion #6 (Spanner template and Parameterized SQL)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noted problems with suggested updates.
DECISION: REJECT and cherrypick
|
This PR adds a new section to the built-in tools documentation explaining how to use customizable template SQL and parameterized SQL with the Spanner toolset, including code examples.