Introduce metrics-transmitter binary
#1812
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjreynol
force-pushed
the
cuttlefish_metrics
branch
4 times, most recently
from
87fb9d0 to
71fb387
Compare
cjreynol
force-pushed
the
cuttlefish_metrics
branch
2 times, most recently
from
a406fa3 to
e5c7de7
Compare
cjreynol
added
kokoro:force-run
GoogleCuttlefishTesterBot
removed
kokoro:run
cjreynol
force-pushed
the
cuttlefish_metrics
branch
5 times, most recently
from
da8fac3 to
882aec7
Compare
cjreynol
changed the title
cuttlefish-metrics packagemetrics-transmitter binary
The idea is to move all of the Google-specific logic into this new binary, then make the binary part of a new package that enables metrics transmission when the package is installed. The package will be introduced later. This commit introduces the binary with duplicate code from the existing conversion and transmission logic, but does not use it or remove the copied code. Bug: 450053679
The team-owned `CuttlefishLogEvent` proto is the new external boundary for the `cvd`-based metrics code. The Google-specific protos and information now all lives in the new `metrics-transmitter` binary, which allows it to be replaced with something not specific to Google. Bug: 450053679
I want to reference both the enum values and strings in multiple places, so I am isolating it to avoid unnecessary dependency chains.
Re-introducing the capability for transmitting metrics, if the boolean enabled flag is set, after the transmission call was removed in a previous commit when adjusting the API boundaries. Bug: 450053679
cjreynol
force-pushed
the
cuttlefish_metrics
branch
from
882aec7 to
c7e3b43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new binary to handle responsibility of transmitting metrics to Google. This is an intermediate step to moving the binary to a new
cuttlefish-metricspackage and having installation of that package be the enabler for metrics.