Skip to content

Conversation

@adelva1984
Copy link
Collaborator

No description provided.

Comment on lines +55 to +66
echo "WARNING: This script MUST be run against an AOSP / publicly released Android tree."
echo "WARNING: Do not run it against an internal Android tree under any circumstance!"
echo
while true; do
read -p "Do you understand the above instructions? " yn
case $yn in
[Yy]* ) break;;
[Nn]* ) exit;;
* ) echo "Please answer yes or no.";;
esac
done
echo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid of getting used to auto-accepting this and accidentally using the wrong one. Is it possible to use a heuristic as a fallback check here? Two options I can think of:

  • Checking git remote -v in one of the source directories has no googleplex-android member.
  • Validating that a known internal-only source directory is not present. vendor/google_devices/cuttlefish_common maybe?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will work on this.

For various code forked from AOSP, some changes have been made. Track
them in numbered patch stacks.
Various AOSP sources are fully copied and forked, and some are also
patched. Make updating these files easier.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants