Skip to content

Add presubmit check to ensure docker image is running on podman as well #1878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
0405ysj wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add presubmit check to ensure docker image is running on podman as well #1878

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 28 additions & 2 deletions .github/workflows/presubmit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ jobs:
tar -xvf debs_amd64.tar
container/image-builder.sh -m dev
- name: Save docker image
run: docker save --output cuttlefish-orchestration.tar cuttlefish-orchestration
run: docker save --output cuttlefish-orchestration.tar cuttlefish-orchestration:latest
- name: Publish docker image
uses: actions/upload-artifact@c7d193f32edcb7bfad88892161225aeda64e9392 # aka v4.0.0
with:
Expand All @@ -264,7 +264,7 @@ jobs:
tar -xvf debs_arm64.tar
container/image-builder.sh -m dev
- name: Save docker image
run: docker save --output cuttlefish-orchestration.tar cuttlefish-orchestration
run: docker save --output cuttlefish-orchestration.tar cuttlefish-orchestration:latest
- name: Publish docker image
uses: actions/upload-artifact@c7d193f32edcb7bfad88892161225aeda64e9392 # aka v4.0.0
with:
Expand Down Expand Up @@ -394,3 +394,29 @@ jobs:
# Run create_from_images_zip_test e2e tests
cd e2etests
bazel test orchestration/create_from_images_zip_test:create_from_images_zip_test_test
podman-image-check:
runs-on: ubuntu-22.04
needs: [build-docker-image-amd64]
steps:
- name: Checkout repository
uses: actions/checkout@a81bbbf8298c0fa03ea29cdc473d45769f953675 # aka v2
- name: Download docker image
uses: actions/download-artifact@v4
with:
name: cuttlefish-orchestration-amd64
- name: Load docker image as podman image
run: |
sudo podman load --input cuttlefish-orchestration.tar
sudo podman image list
- name: Run check
shell: bash
run: |
sudo podman run --privileged -d -p 2080:2080 docker.io/library/cuttlefish-orchestration:latest
# Wait for HO service to start.
sleep 10s
res=$( curl -v http://localhost:2080/cvds )
echo "response: ${res}"
test "${res}" = '{"cvds":[]}'
# Run create_from_images_zip_test e2e tests
cd e2etests
bazel test orchestration/create_from_images_zip_test:create_from_images_zip_test_test
Loading