Use INADDR_LOOPBACK for adb serial#2609
Merged
Merged
Conversation
Instead of INADDR_ANY. INADDR_ANY is still used on the host side proxy to accept connections on all network interfaces. When issuing the `adb connect` command though, the loopback address is used as it's more specific. The loopback address is also more likely to be used when the user (or an agent on their behalf) executes the `adb connect` command. If the user tries to connect to the same port with a different address, the adb server will create a new connection with the device and list it separately from the one created by adb_connection_maintainer. Bug: b/516816243
ser-io
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of INADDR_ANY. INADDR_ANY is still used on the host side proxy to accept connections on all network interfaces.
When issuing the
adb connectcommand though, the loopback address is used as it's more specific.The loopback address is also more likely to be used when the user (or an agent on their behalf) executes the
adb connectcommand. If the user tries to connect to the same port with a different address, the adb server will create a new connection with the device and list it separately from the one created by adb_connection_maintainer.Bug: b/516816243