Skip to content

Conversation

@syslogic
Copy link

@syslogic syslogic commented Mar 16, 2025

Have now started over, since the rebasing didn't work that well.
This also builds with: ./tools/buildutils/build_packages.sh

Currently just unsure about the changed bazel build target.
And the TypeScript server_connector.d.ts might not be required.

@syslogic syslogic mentioned this pull request Mar 16, 2025
@0405ysj 0405ysj added the kokoro:run Run e2e tests. label Mar 17, 2025
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed the kokoro:run Run e2e tests. label Mar 17, 2025
@daedroza
Copy link

Hello, thank you for putting this up - we've missed to update the instructions for installing for the rpm packages using dnf!

@syslogic
Copy link
Author

syslogic commented Mar 25, 2025

Since the build targets have changed, I'm not sure anymore, that everything required is being built. I mean, this would a) not only require a code review, but a resulting package review, in order to make sure everything is installed where it belongs and that there are no useless files contained.

b) This would also require a rpm-builder workflow, because the hosted runner images are all Debian based.

c) Also not sure, if the Wayland package dependencies would suffice.

@syslogic
Copy link
Author

syslogic commented Mar 27, 2025

The rpm-builder.yml workflow is merely working and that's the Dockerfile.
Haven't built any packages so far, because the build-time is rather limited.
I'm still trying to upload the built RPM packages as GitHub runner artifacts.

@ser-io ser-io marked this pull request as draft March 28, 2025 18:36
@ser-io
Copy link
Member

ser-io commented Mar 28, 2025

@syslogic thanks for your contribution. Converted the PR to Draft as it seems it's still work in progress and it's spamming the reviewers on every push. Feel free to mark it "Ready for review" once ready.

@syslogic
Copy link
Author

syslogic commented Mar 30, 2025

@ser-io I was extensively testing the workflow to provide the RHEL environment for building *.rpm from these *.spec files on GitHub, because the runner images are all Ubuntu. And it seems the entrypoint scripts are occassionally stuck at an obsolete version, which is a problem. I could even automate RPM package signature, when having a GPG *.asc signature and passphrase set up as secrets, and the upload to RPM repository. This PR now exceeds the maximum commit limit; will start a new PR.

@syslogic syslogic closed this Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants