Add new Cargo fetch tests and remove old mocked pseudo-test #1776
+194
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Snapshot diff report vs base branch: main |
timothyfroehlich
force-pushed
the
wb/froeht/new-fetch-test
branch
2 times, most recently
from
6593cc1
to
fb26053
Compare
rylin8
reviewed
Nov 12, 2024
timothyfroehlich
force-pushed
the
wb/froeht/new-fetch-test
branch
3 times, most recently
from
68c6baf
to
0576fcb
Compare
rylin8
approved these changes
Nov 13, 2024
This adds a new Cargo fetch test to check that a doc can be fetched and serialized. Because we don't want GitHub to be trying to fetch files, it's locked behind a new feature, "test_fetches". This also removes the figma_v1_mock file and feature. This was a pseudo test that wasn't being executed by anything. It worked by using a feature flag to mock the http fetch, which meant that if the feature flag was included that no http queries would work, including the new fetch test.
timothyfroehlich
force-pushed
the
wb/froeht/new-fetch-test
branch
from
0576fcb
to
f2c22b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tree of downstream PRs as of 2024-11-12
PR Add new Cargo fetch tests and remove old mocked pseudo-test #1776 (THIS ONE):
main←wb/froeht/new-fetch-testPR Convert the positioning enums and LayoutView to Proto #1774:
wb/froeht/new-fetch-test←wb/froeht/protoconv-layout-positioningwb/froeht/protoconv-layout-positioning←wb/froeht/1731-meter-dataThis adds a new Cargo fetch test to check that a doc can be fetched and serialized. Because we don't want GitHub to be trying to fetch files, it's locked behind a new feature, "test_fetches".
This also removes the figma_v1_mock file and feature. This was a pseudo test that wasn't being executed by anything. It worked by using a feature flag to mock the http fetch, which meant that if the feature flag was included that no http queries would work, including the new fetch test.