Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[clang-tidy] resolve some global clang-tidy issues #1933

Merged
merged 4 commits into from
Feb 18, 2025
Merged

[clang-tidy] resolve some global clang-tidy issues #1933

merged 4 commits into from
Feb 18, 2025

Conversation

dmah42
Copy link
Member

@dmah42 dmah42 commented Feb 13, 2025

part of #1925

LebedevRI
LebedevRI reviewed Feb 13, 2025
View reviewed changes
@dmah42 dmah42 marked this pull request as ready for review February 17, 2025 17:18
LebedevRI
LebedevRI previously approved these changes Feb 18, 2025
View reviewed changes
Copy link
Collaborator

@LebedevRI LebedevRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine.

@dmah42 dmah42 merged commit 9514292 into main Feb 18, 2025
96 of 101 checks passed
@dmah42 dmah42 deleted the globals branch February 18, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LebedevRI LebedevRI LebedevRI left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmah42 @LebedevRI