Add an option to exclude based on source names#234
Open
learn-more wants to merge 1 commit intogoogle:mainfrom
Open
Add an option to exclude based on source names#234learn-more wants to merge 1 commit intogoogle:mainfrom
learn-more wants to merge 1 commit intogoogle:mainfrom
Conversation
Contributor
Author
|
@haberman apart from the merge conflict, anything here that should be improved? |
haberman
requested changes
Aug 3, 2021
Member
haberman
left a comment
haberman
left a comment
There was a problem hiding this comment.
This looks great, just a few comments.
| --source-filter=PATTERN | ||
| Only show keys with names matching this pattern. | ||
| --not-source-filter=PATTERN | ||
| Exclude keys with names matching this pattern. |
Member
There was a problem hiding this comment.
We should document what happens if a name matches both --source-filter and --exclude-source-filter.
Contributor
Author
There was a problem hiding this comment.
I wrote a test that shows what happens, basically nothing is output other than the fact that everything is omitted.
Contributor
Author
There was a problem hiding this comment.
This has been added the the help text.
Contributor
Author
learn-more
force-pushed
the
not_source_filter
branch
from
3f2ed6d to
d59d47d
Compare
learn-more
force-pushed
the
not_source_filter
branch
from
d59d47d to
3865005
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#203
This includes a testcase for both include and exclude.