Fix crash in StrictSubstr on -ohos artifacts#390
Open
jschwe wants to merge 1 commit intogoogle:mainfrom
Open
Conversation
Fixes a "region out-of-bounds" assertion failure in StrictSubstr. When `remaining_` is just the "\0" character we are done and should return.
Collaborator
|
@jschwe Thanks for the proposed fix! I rebased and tested this and it looks like it regresses a few tests: I'm guessing the fix is a bit more nuanced. It might be worth filing an issue including a binary that reproduces to track this. If you're up for it we'd want to add a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a "region out-of-bounds" assertion failure in StrictSubstr when running bloaty on a Rust shared library compiled for
aarch64-unknown-linux-ohos.When
remaining_is just the "\0" character, we are done and should return.