Refactor fuzzingsession #4374
Open
Refactor fuzzingsession #4374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanmetzman
force-pushed
the
fuzzt
branch
from
2b946a8
to
22a2d5d
Compare
vitorguidi
reviewed
Nov 4, 2024
| start_time = time.time() | ||
| result = self._run_common() | ||
| if result: | ||
| return result |
There was a problem hiding this comment.
Probably worth moving the metric from #4336 to a decorator as you pointed out, we are losing instrumentation in this early return.
vitorguidi
reviewed
Nov 4, 2024
| return result | ||
|
|
||
| # TODO(metzman): Move this section into seperate functions for engine and | ||
| # blackbox fuzzing instead of sandwhiching with ifs for engine fuzzing. |
There was a problem hiding this comment.
Is this being done at this PR, or in a follow up one?
There was a problem hiding this comment.
A following one. That's generally what TODOs mean.
jonathanmetzman
force-pushed
the
master
branch
from
a714059
to
f4df493
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start preparing to seperate code dealing with engine and non-engine fuzzing.