Swarming: Adds CountTasks endpoint & Refactors swarming Prpc request#5277
Open
IvanBM18 wants to merge 2 commits into
Open
Swarming: Adds CountTasks endpoint & Refactors swarming Prpc request#5277IvanBM18 wants to merge 2 commits into
IvanBM18 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the Swarming backpressure initiative, we needed to launch request to the prpc's
swarming.v2.Task/CountTasksendpoint to achieve this i moved the logic prpc logic to its own module to reuse code and keep responsibilities in separate files.Changes
api.pyfile in the swarming module.__init__.pytoapi.pySwarmingAPIto handle the prpc request logic such as token/auth logic, swarming config handling, and any other request logicTests
Note:
This PR is dependendant to this other PR any changes you see related to the proto files are to be reviewed in said pr.