ja: Translate Chapter 25 (Traits) #1436
Conversation
|
FYI (You can stop reading if you don't use a MacBook) Looks like the previous commit (a5f938f) had italic double quotes, which failed its Japanese Github Actions job. When I copy and pasted snippets from original one to translation box in Poedit, my Mac automatically converted double quotes to italic ones. This is fancy but not the best for programmers, haha :) I have disabled the feature by following the guide: https://blog.piyo.tech/posts/2014-01-06-205101/ The double quotes were fixed by the commit, cb4b5d6. |
|
@HidenoriKobayashi would you mind reviewing this PR? |
|
Thanks @HidenoriKobayashi for great feedback, espesh checking readability of my translation. I've applied most of the suggestions except two --- I left two comments. Could you have a look at them? Have a good holiday! Shortcuts to open threads to save your minuets |
|
Thanks @keiichiw -san, I have applied suggestions; I added several footnotes in the paragraphs with parenthesis, e.g., "trait bounds" translation discussions. Could you review the diff? Any feedback is appreaciated. Cheers! |
|
Ah, some of the github actions checks have failed. I'll take a look into this. |
Sorry, that is my mistake... it'll be fixed with #1472! |
You are welcome to review that PR so it can be auto-merged. That will unblock the build for you and others 🙂 Then we can clean up any left-over problems afterwards. |
OK, I try to take a look into this! |
Hi, this is a tiny MR to add glossary entry for "trait bound". Could you someone review it? I'm open to suggeston, too. Thank you! Context: #1436 (comment)
Hi, this is a tiny MR to add glossary entry for "trait bound". Could you someone review it? I'm open to suggeston, too. Thank you! Context: google#1436 (comment)
|
Hey all, thanks for keeping working on the translation! I think most comments above were incorporated, so perhaps we can merge this? |
Konnichiwa, JP translation folks #652. Here's a MR for Traits chapter. I'm open to suggestions and feedback :) Could you take a look at it? Thank you!