Skip to content

Conversation

@angela28chen
Copy link
Collaborator

@angela28chen angela28chen commented Nov 25, 2025

No description provided.

@angela28chen
Copy link
Collaborator Author

angela28chen commented Nov 25, 2025

I have no idea how to test my changes to the jinja file if it's not being tested by the normal host tools build process.

Edit: Useful context: b/430643434. It appears that generateSOAs.py is run manually and infrequently and the process is not documented. I have tried running python generateSOAs.py event_state.json from the dive_core subfolder to test these changes (appears that event_state C++ files not altered)

@shanminchao If you can provide some context on which files need to be generated with this python script (if there are files other than event_state.json) and if pybind11 is still required or not, that would be really helpful

wangra-google
wangra-google previously approved these changes Nov 25, 2025
@angela28chen angela28chen marked this pull request as ready for review November 25, 2025 20:36
RenfengLiu
RenfengLiu previously approved these changes Nov 27, 2025
@shanminchao
Copy link
Collaborator

As far as I know, pybind11 is not used at all by generateSOAs.py. I manually tested this just now using this PR by modifying one of the descriptions in the event_state.json file, ran the script, and found all the appropriate auto-generated files modified. So as far as I'm concerned, this PR is approved.

@angela28chen angela28chen enabled auto-merge (squash) December 4, 2025 16:29
@angela28chen angela28chen merged commit c261121 into google:main Dec 4, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants