-
Notifications
You must be signed in to change notification settings - Fork 11
Remove pybind11 submodule #593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I have no idea how to test my changes to the jinja file if it's not being tested by the normal host tools build process. Edit: Useful context: b/430643434. It appears that generateSOAs.py is run manually and infrequently and the process is not documented. I have tried running @shanminchao If you can provide some context on which files need to be generated with this python script (if there are files other than event_state.json) and if pybind11 is still required or not, that would be really helpful |
7df525b to
b87ad8c
Compare
b87ad8c to
de8db66
Compare
8a0b41f
8a0b41f to
9c43567
Compare
|
As far as I know, pybind11 is not used at all by generateSOAs.py. I manually tested this just now using this PR by modifying one of the descriptions in the event_state.json file, ran the script, and found all the appropriate auto-generated files modified. So as far as I'm concerned, this PR is approved. |
No description provided.