fix(go): capture local template in Compile closure to prevent sharing #363
+89
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Compile()method where all compiledPromptFunctionclosures shared the samedp.TemplateTestCompileMultiplePromptsTemplateIsolationto prevent future regressionsProblem
When using the
Compile()method multiple times on the sameDotpromptinstance, all compiledPromptFunctionclosures share the samedp.Templatefield. This causes subsequent prompt executions to use the wrong template.Root Cause
In
dotprompt.go, theCompilemethod:renderTplfrom parsing the sourcedp.Templatefield viainitializeTemplate()renderFuncthat referencesdp.TemplateWhen another prompt is compiled,
dp.Templategets overwritten, causing all previousrenderFuncclosures to use the wrong template.Example
Solution
Capture the current template in a local variable before creating the closure:
Test Plan
TestCompileMultiplePromptsTemplateIsolationregression testFixes #362