Vk protected content command buffer #8241
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the basic mechanisms for creating and managing the protected state. We also create the queue and get it. Finally we allocate protected memory.
Addressing all the feedbacks from the pull request.
Part 2: - Removing some of the shared context logic - Cleaning up spacing issues - Removing accessors
Line length, variable name.
The lack of type was causing VK to not properly fill the strucutres.
Command buffer protection is added.
Constructor Modification.
Argument ordering was wrong.
The command buffers are now protected and able to submit work.
As expressed we took the new implementation and tried applied it to the branch. Needed for testing on the Moohan side.
The depth buffer creation takes a different path potentially not getting picked up for depth creation.
poweifeng
reviewed
Oct 31, 2024
| @@ -33,453 +33,504 @@ using namespace utils; | |||
|
|
|||
| namespace filament::backend { | |||
|
|
|||
| namespace { | |||
There was a problem hiding this comment.
The spacing is different for this file.
the base classes and namespace should have no spacing in front.
| @@ -111,6 +111,15 @@ class VulkanDriver final : public DriverBase { | |||
|
|
|||
| private: | |||
| void collectGarbage(); | |||
| inline VulkanCommandBuffer& getCommandBuffer() { | |||
There was a problem hiding this comment.
let's remove this and also mIsRenderPassProtected and mIsContentProtected
| @@ -185,8 +185,9 @@ struct PushConstantDescription { | |||
|
|
|||
| uint32_t getVkRangeCount() const noexcept { return mRangeCount; } | |||
|
|
|||
| void write(VulkanCommands* commands, VkPipelineLayout layout, backend::ShaderStage stage, | |||
| uint8_t index, backend::PushConstantVariant const& value); | |||
| void write(VulkanCommands* commands, bool isProtected, VkPipelineLayout layout, | |||
There was a problem hiding this comment.
let's not change VulkanHandles in this PR
| @@ -29,7 +29,7 @@ namespace filament::backend { | |||
| namespace { | |||
|
|
|||
| std::tuple<VkImage, VkDeviceMemory> createImageAndMemory(VulkanContext const& context, | |||
| VkDevice device, VkExtent2D extent, VkFormat format) { | |||
| VkDevice device, VkExtent2D extent, VkFormat format, bool isProtected) { | |||
There was a problem hiding this comment.
Can you do this in a separate PR?
Unused variable in release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second phase of the protected content work. This includes the protected command buffer, and the associated scheduling and submission work. We also introduce a getProtected method in the VulkanCommands object for specific cases where protection level is activated.