Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support optional finding of externals instead of subdirectories #8266

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aminya
Copy link

@aminya aminya commented Nov 10, 2024

Fixes #5957

This adds an option to allow usage of external targets that are found via find_package and find_path instead of adding them via add_subdirectory. The implementation will fallback to the directories if a target/header cannot be found.

This is cherry-picked from my PR for allowing filament to be built via vcpkg:
microsoft/vcpkg#41916

@pixelflinger pixelflinger added the internal Issue/PR does not affect clients label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Issue/PR does not affect clients
Projects
None yet
Development

Successfully merging this pull request may close these issues.

filament conflicts with other packages. please allow to use external dependencies
2 participants