vk: Use-after-free coverage #8273
Open
+37
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixelflinger
requested changes
Nov 14, 2024
Comment on lines
+63
to
+67
| if (UTILS_UNLIKELY(ptr->isHandleConsideredDestroyed())) { | ||
| FILAMENT_CHECK_PRECONDITION(!ptr->isHandleConsideredDestroyed()) | ||
| << "Handle id=" << ptr->id << " (" << getTypeStr(ptr->restype) | ||
| << ") is being used after it has been freed"; | ||
| } |
There was a problem hiding this comment.
you don't need the if here, FILAMENT_CHECK_PRECONDITION already does all the likely/unlikely shenanigans
There was a problem hiding this comment.
I was trying to avoid hitting the switch in getTypeStr unless necessary, hence the roundabout logic here.
Do you think it's worth it or not? (or maybe it just going to be speculatively executed anyways?).
| @@ -156,6 +162,7 @@ struct resource_ptr { | |||
| // only be used from VulkanDriver. | |||
| inline void dec() { | |||
| assert_invariant(mRef); | |||
| mRef->setHandleConsiderDestroyed(); | |||
There was a problem hiding this comment.
should we at least assert_invariant() here that the handle is not already in the considered destroyed state? (I think this should never happen right?).
To allow for use-after-free discovery with ref-counting, we keep a bit to indicate whether the handle is considered destroyed by Filament. We assert against "cast"-ing a destroyed handle.
poweifeng
force-pushed
the
pf/vk-handle-use-after-free
branch
from
8e7cc08
to
3e6ceaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow for use-after-free discovery with ref-counting, we keep a bit to indicate whether the handle is considered destroyed by Filament. We assert against "cast"-ing a destroyed handle.