Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build when fgviewer is manually enabled #8451

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pixelflinger
Copy link
Collaborator

No description provided.

@pixelflinger pixelflinger added the internal Issue/PR does not affect clients label Feb 18, 2025
@show50726
Copy link
Contributor

We may also want to uncomment the lines around 541?

@pixelflinger
Copy link
Collaborator Author

We may also want to uncomment the lines around 541?

I think that one is not strictly necessary right? That one just makes it the default when DEBUG.

@poweifeng
Copy link
Contributor

We may also want to uncomment the lines around 541?

I think that one is not strictly necessary right? That one just makes it the default when DEBUG.

I think it is necessary because one could run cmake outside of build.sh, in which case, we'd get an undefined option for debug builds (I think).

@show50726
Copy link
Contributor

We may also want to uncomment the lines around 541?

I think that one is not strictly necessary right? That one just makes it the default when DEBUG.

I think it is necessary because one could run cmake outside of build.sh, in which case, we'd get an undefined option for debug builds (I think).

I think there would not be error if an option is undefined (however the behavior might not always be as expected).

BTW, I think if we want to make users able to build and use fgviewer, I opened another PR with all necessary changes: #8453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Issue/PR does not affect clients
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants