add a feature flag to control handle tags for heap handles #8463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heap allocated handle tags are kept forever and we suspect this is causing problems. the new feature flag "backend.disable_heap_handle_tags" is enabled by default and controls if we store these tags at all or not. BUGS=[397766275]
poweifeng
approved these changes
Feb 20, 2025
| @@ -67,7 +68,8 @@ class DebugTag { | |||
| template<size_t P0, size_t P1, size_t P2> | |||
| class HandleAllocator : public DebugTag { | |||
| public: | |||
| HandleAllocator(const char* name, size_t size, bool disableUseAfterFreeCheck) noexcept; | |||
| HandleAllocator(const char* name, size_t size, | |||
| bool disableUseAfterFreeCheck, bool disableHeapHandleTags = false) noexcept; | |||
There was a problem hiding this comment.
nit: why the = false default?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
heap allocated handle tags are kept forever and we suspect this is causing problems. the new feature flag "backend.disable_heap_handle_tags" is enabled by default and controls if we store these tags at all or not.
BUGS=[397766275]