Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edu AU VIC WA NT Cursive: Version 1.000 added #7449

Closed
wants to merge 6 commits into from

Conversation

simoncozens
Copy link
Collaborator

Taken from the upstream repo https://github.com/SorkinType/VICWANTSchoolHandAustralia at commit SorkinType/VICWANTSchoolhandAustralia@abab94d.

PR Checklist:

  • Family categorization tags collected from the type design team with the Categories Form
  • Minisite_url definition in the METADATA.pb file for commissioned projects
  • Primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target
  • Fontbakery checks are reviewed and failing checks are resolved in collaboration with the upstream font development team
  • Diffenator2 regression checks for revisions on all projects that are currently in production
  • Designers bio info have to be present in the designer catalog (at least an issue should be opened for tracking this, if they are not)
  • Check designers order in metadata.pb, since the first one of the list appears as “principal designer”
  • Social media formatted visual assets for all new commissioned projects in the Drive directory, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet
  • Social media content draft for all new commissioned projects in the Drive directory and Social Media tracker spreadsheet, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet

This comment was marked as outdated.

This comment was marked as outdated.

@simoncozens
Copy link
Collaborator Author

I want to fix the connections of glyphs with accents before we merge this. @EbenSorkin is testing.

@simoncozens simoncozens added the -- Upstream is working on it Designer is making changes in the upstream repo label Apr 5, 2024
@simoncozens simoncozens changed the title Edu VIC WA NT Cursive: Version 1.000 added Edu AU VIC WA NT Cursive: Version 1.000 added Jul 16, 2024
@simoncozens simoncozens force-pushed the gftools_packager_ofl_eduvicwantcursive branch from 4c7ca3f to d60c695 Compare July 16, 2024 15:12

This comment was marked as outdated.

@simoncozens simoncozens removed the -- Upstream is working on it Designer is making changes in the upstream repo label Jul 16, 2024

This comment was marked as outdated.

Copy link

FontBakery report

fontbakery version: 0.12.8

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[2] EduAUVICWANTCursive[wght].ttf
🔥 FAIL Ensure 'smcp' (small caps) lookups are defined before ligature lookups in the 'GSUB' table.
  • 🔥 FAIL

    'smcp' or 'liga' lookups not found in GSUB table.


    [code: missing-lookups]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Family metadata at ofl/eduauvicwantcursive does not have an article.


    [code: lacks-article]

All other checks

[18] EduAUVICWANTCursive[wght].ttf
🔥 FAIL Shapes languages in all GF glyphsets.
  • 🔥 FAIL

    GF_Latin_Core glyphset:

Language FAIL messages
lt_Latn (Lithuanian) Shaper didn't attach ogonekcomb to idotless.fina
[code: failed-language-shaping]
🔥 FAIL Combined length of family and style must not exceed 32 characters.
  • 🔥 FAIL

    Variable font instance name 'Edu AU VIC WA NT Cursive SemiBold' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 274 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long]
⚠️ WARN Check math signs have the same width.
  • ⚠️ WARN

    The most common width is 1017 among a set of 4 math glyphs.
    The following math glyphs have a different width, though:

Width = 961: less

Width = 962: greater

Width = 1042: plusminus

Width = 1011: multiply

Width = 1052: approxequal

Width = 1037: notequal

Width = 1039: lessequal, greaterequal

[code: width-outliers]
⚠️ WARN Font has **proper** whitespace glyph names?
  • ⚠️ WARN

    Glyph 0x00A0 is called "nbspace": Change to "uni00A0"


    [code: not-recommended-00a0]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: tifinagh, canadian-aboriginal, yi
  • U+02D8 BREVE: try adding one of: canadian-aboriginal, yi
  • U+02D9 DOT ABOVE: try adding one of: canadian-aboriginal, yi
  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi
  • U+02DD DOUBLE ACUTE ACCENT: not included in any glyphset definition
  • U+0302 COMBINING CIRCUMFLEX ACCENT: try adding one of: math, tifinagh, cherokee, coptic
  • U+0306 COMBINING BREVE: try adding one of: tifinagh, old-permic
  • U+0307 COMBINING DOT ABOVE: try adding one of: tifinagh, old-permic, malayalam, syriac, coptic, math, canadian-aboriginal, tai-le
  • U+030A COMBINING RING ABOVE: try adding syriac
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage 37 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: latin, latin-ext, menu

[code: unreachable-subsetting]
⚠️ WARN Ensure files are not too large.
  • ⚠️ WARN

    Font file is 1.2Mb; ideally it should be less than 1.0Mb


    [code: large-font]
⚠️ WARN Is there kerning info for non-ligated sequences?
  • ⚠️ WARN

    GPOS table lacks kerning info for the following non-ligated sequences:

- f + i

- f + l

[code: lacks-kern-info]

⚠️ WARN Check font follows the Google Fonts vertical metric schema
  • ⚠️ WARN

    We recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.7395x (3479)


    [code: bad-hhea-range]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/eduauvicwantcursive


    [code: family-path]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

- vhea

- vmtx

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
  • ℹ️ INFO

    This font doesn't have an ARTICLE.en_us.html file.


    [code: missing-article]
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/eduauvicwantcursive/EduAUVICWANTCursive[wght].ttf
Dehinted Size 1.2Mb
Hinted Size 1.2Mb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ℹ️ INFO

    Latn


    [code: dlng-tag]

  • ℹ️ INFO

    Latn


    [code: slng-tag]

ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.001']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 1)

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 3 7 43 11 187 0
0% 0% 1% 3% 17% 4% 75% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@simoncozens simoncozens linked an issue Aug 13, 2024 that may be closed by this pull request
9 tasks
@vv-monsalve
Copy link
Collaborator

@simoncozens, @EbenSorkin

  • Please review the quotes spacing or kerning. Next to s the quotes look like diacritic marks
    Screenshot 2024-08-15 at 22 04 43

@vv-monsalve vv-monsalve added the -- Needs confirmation from upstream or onboarder label Aug 16, 2024
@EbenSorkin
Copy link
Collaborator

EbenSorkin commented Aug 16, 2024 via email

@vv-monsalve vv-monsalve added -- Needs Upstream Resolution Upstream fix required before moving forward and removed -- Needs confirmation from upstream or onboarder labels Aug 20, 2024
@emmamarichal emmamarichal linked an issue Oct 11, 2024 that may be closed by this pull request
@emmamarichal emmamarichal removed a link to an issue Oct 11, 2024
9 tasks
@simoncozens
Copy link
Collaborator Author

Closing in favour of #8320, which fixes the spacing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-- Needs Upstream Resolution Upstream fix required before moving forward I New Font
Projects
Status: PR GF
Development

Successfully merging this pull request may close these issues.

3 participants