-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edu AU VIC WA NT Cursive: Version 1.000 added #7449
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
I want to fix the connections of glyphs with accents before we merge this. @EbenSorkin is testing. |
4c7ca3f
to
d60c695
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
FontBakery reportfontbakery version: 0.12.8 Experimental checksThese won't break the CI job for now, but will become effective after some time if nobody raises any concern. [2] EduAUVICWANTCursive[wght].ttfAll other checks[18] EduAUVICWANTCursive[wght].ttf🔥 FAIL Shapes languages in all GF glyphsets.
🔥 FAIL Combined length of family and style must not exceed 32 characters.
This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11. [code: instance-too-long]
|
ofl/eduauvicwantcursive/EduAUVICWANTCursive[wght].ttf | |
---|---|
Dehinted Size | 1.2Mb |
Hinted Size | 1.2Mb |
Increase | 24 bytes |
Change | 0.0 % |
[1] Family checks
Summary
💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
---|---|---|---|---|---|---|---|
0 | 0 | 3 | 7 | 43 | 11 | 187 | 0 |
0% | 0% | 1% | 3% | 17% | 4% | 75% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
That does look like excessive kerning tp me.
I can do a pass on it on Friday.
…On Thu, Aug 15, 2024 at 11:13 PM Viviana Monsalve ***@***.***> wrote:
@simoncozens <https://github.com/simoncozens>, @EbenSorkin
<https://github.com/EbenSorkin>
- Please review the quotes spacing or kerning. Next to s the quotes
look like diacritic marks
Screenshot.2024-08-15.at.22.04.43.png (view on web)
<https://github.com/user-attachments/assets/1b73a189-e13b-47f9-adf3-09197f38d90d>
—
Reply to this email directly, view it on GitHub
<#7449 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQUQXL23NODQYUCMAI6EXTZRVU47AVCNFSM6AAAAABE7NSK22VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJSGY2TENBVHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Closing in favour of #8320, which fixes the spacing issue. |
Taken from the upstream repo https://github.com/SorkinType/VICWANTSchoolHandAustralia at commit SorkinType/VICWANTSchoolhandAustralia@abab94d.
PR Checklist: