Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edu AU VIC WA NT Arrows Guides: Version 1.001 added #7873

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

simoncozens
Copy link
Collaborator

Taken from the upstream repo https://github.com/SorkinType/VICWANTSchoolhandAustralia at commit SorkinType/VICWANTSchoolhandAustralia@7ebdd5a.

PR Checklist:

  • Family categorization tags collected from the type design team with the Categories Form
  • Minisite_url definition in the METADATA.pb file for commissioned projects
  • Primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target
  • Fontbakery checks are reviewed and failing checks are resolved in collaboration with the upstream font development team
  • Diffenator2 regression checks for revisions on all projects that are currently in production
  • Designers bio info have to be present in the designer catalog (at least an issue should be opened for tracking this, if they are not)
  • Check designers order in metadata.pb, since the first one of the list appears as “principal designer”
  • Social media formatted visual assets for all new commissioned projects in the Drive directory, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet
  • Social media content draft for all new commissioned projects in the Drive directory and Social Media tracker spreadsheet, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet

@simoncozens simoncozens force-pushed the gftools_packager_ofl_eduauvicwantarrowsguides branch from b350323 to 2068515 Compare June 20, 2024 13:59

This comment was marked as outdated.

@simoncozens
Copy link
Collaborator Author

Now we have the apex VF onboarded I'm going to work on the variants.

This font only contains A-Z a-z 0-9 and space, so many of the fontbakery fails are unsurprising.

@emmamarichal
Copy link
Collaborator

Numbers don't have any arrows. Is it intentional? @simoncozens @EbenSorkin

Screenshot 2024-06-21 at 12 01 24

@emmamarichal emmamarichal added the -- Needs confirmation from upstream or onboarder label Jun 21, 2024
@simoncozens
Copy link
Collaborator Author

Nope, that's a fix for @EbenSorkin please!

@EbenSorkin
Copy link
Collaborator

EbenSorkin commented Jun 21, 2024 via email

@emmamarichal emmamarichal added -- Needs Upstream Resolution Upstream fix required before moving forward and removed -- Needs confirmation from upstream or onboarder labels Jun 27, 2024
@vv-monsalve
Copy link
Collaborator

I can make those. I forget if we even have dotted ones.

@EbenSorkin do you have an estimated time for this fix?

@EbenSorkin
Copy link
Collaborator

EbenSorkin commented Aug 19, 2024 via email

@vv-monsalve
Copy link
Collaborator

vv-monsalve commented Aug 20, 2024

I can probably do it this evening.

but I’ll want to get that started when the moment comes that it’s not disruptive to do it.

Let's solve and merge this PR with the basic initial glyph set that was agreed upon. Then, they can all be upgraded in a second phase related to adding language support.

@simoncozens simoncozens removed the -- Needs Upstream Resolution Upstream fix required before moving forward label Sep 6, 2024
Copy link

github-actions bot commented Sep 6, 2024

FontBakery report

fontbakery version: 0.12.10

Check results

[23] EduAUVICWANTArrowsGuides[wght].ttf
🔥 FAIL Checking correctness of monospaced metadata.
  • 🔥 FAIL

    Value of hhea.advanceWidthMax should be set to 2337 but got 2586 instead.


    [code: bad-advanceWidthMax]
🔥 FAIL MaxAdvanceWidth is consistent with values in the Hmtx and Hhea tables?
  • 🔥 FAIL

    AdvanceWidthMax mismatch: expected 2337 (from hmtx); got 2586 (from hhea)


    [code: mismatch]
🔥 FAIL Whitespace glyphs have ink?
  • 🔥 FAIL

    Glyph 'space' has ink. It needs to be replaced by an empty glyph.


    [code: has-ink]

  • 🔥 FAIL

    Glyph 'uni00A0' has ink. It needs to be replaced by an empty glyph.


    [code: has-ink]

🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.
🔥 FAIL Shapes languages in all GF glyphsets.
  • 🔥 FAIL

    No GF glyphset was found to be supported >80%, so language shaping support couldn't get checked.


    [code: no-glyphset-supported]
🔥 FAIL Combined length of family and style must not exceed 32 characters.
  • 🔥 FAIL

    Variable font instance name 'Edu AU VIC WA NT Arrows Guides Regular' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 276 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long]
  • 🔥 FAIL

    Variable font instance name 'Edu AU VIC WA NT Arrows Guides Medium' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 278 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long]
  • 🔥 FAIL

    Variable font instance name 'Edu AU VIC WA NT Arrows Guides SemiBold' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 280 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long]
  • 🔥 FAIL

    Variable font instance name 'Edu AU VIC WA NT Arrows Guides Bold' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 282 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long]
  • ⚠️ WARN

    Name ID 6 'EduAUVICWANTArrowsGuides-Regular' exceeds 27 characters. This has been found to cause problems with PostScript printers, especially on Mac platforms.


    [code: nameid6-too-long]
🔥 FAIL Copyright notices match canonical pattern in fonts
  • 🔥 FAIL

    Copyright notices differ between name table entries and METADATA.pb.The following copyright values were found:

- Copyright 2023 The VIC WA NT School Hand Australia Project Authors (https://github.com/SorkinType/VICWANTSchoolhandAustralia): Name Table entry

- Copyright 2023 The VIC WA NT School Hand Australia Project Authors (https://github.com/SorkinType/VICWANTSchoolHandAustralia): METADATA.pb

[code: mismatch]

🔥 FAIL Check Google Fonts glyph coverage.
  • 🔥 FAIL

    Missing required codepoints:

- 0x0021 (EXCLAMATION MARK)


- 0x0022 (QUOTATION MARK)


- 0x0023 (NUMBER SIGN)


- 0x0024 (DOLLAR SIGN)


- 0x0025 (PERCENT SIGN)


- 0x0026 (AMPERSAND)


- 0x0027 (APOSTROPHE)


- 0x0028 (LEFT PARENTHESIS)


- 0x0029 (RIGHT PARENTHESIS)


- 0x002A (ASTERISK)


- 245 more.

Use -F or --full-lists to disable shortening of long lists.

[code: missing-codepoints]
⚠️ WARN Font has correct post table version?
  • ⚠️ WARN

    Post table format 3 use has niche use case problems.Please review the check rationale for additional details.


    [code: post-table-version]
⚠️ WARN Check if OS/2 xAvgCharWidth is correct.
  • ⚠️ WARN

    OS/2 xAvgCharWidth is 1129 but it should be 1179 which corresponds to the average of the widths of all glyphs in the font.


    [code: xAvgCharWidth-wrong]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Family metadata at ofl/eduauvicwantarrowsguides does not have an article.


    [code: lacks-article]
⚠️ WARN Are there any misaligned on-curve points?
  • ⚠️ WARN

    The following glyphs have on-curve points which have potentially incorrect y coordinates:

* J (U+004A): X=-0.5,Y=2.0 (should be at baseline 0?)

* J (U+004A): X=-0.5,Y=2.0 (should be at baseline 0?)

* K (U+004B): X=1495.0,Y=1848.5 (should be at cap-height 1847?)

* K (U+004B): X=1495.0,Y=1848.5 (should be at cap-height 1847?)

* Q (U+0051): X=718.0,Y=-1.0 (should be at baseline 0?)

* Q (U+0051): X=718.0,Y=-1.0 (should be at baseline 0?)

* V (U+0056): X=1320.5,Y=1845.0 (should be at cap-height 1847?)

* V (U+0056): X=1320.5,Y=1845.0 (should be at cap-height 1847?)

* W (U+0057): X=2273.5,Y=1845.0 (should be at cap-height 1847?)

* W (U+0057): X=2273.5,Y=1845.0 (should be at cap-height 1847?)

* 48 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-misalignments]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
⚠️ WARN Check font follows the Google Fonts vertical metric schema
  • ⚠️ WARN

    We recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.7395x (3479)


    [code: bad-hhea-range]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/eduauvicwantarrowsguides


    [code: family-path]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

- vhea

- vmtx

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
  • ℹ️ INFO

    This font doesn't have an ARTICLE.en_us.html file.


    [code: missing-article]
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/eduauvicwantarrowsguides/EduAUVICWANTArrowsGuides[wght].ttf
Dehinted Size 101.3kb
Hinted Size 101.4kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.001']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 1)

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 8 6 52 10 175 0
0% 0% 3% 2% 21% 4% 70% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@emmamarichal
Copy link
Collaborator

emmamarichal commented Sep 20, 2024

@simoncozens
Probably because of 🔥 FAIL Combined length of family and style must not exceed 32 characters.:
There are several issues in menus (Indesign and Word on Mac, and Word on Windows).

Behaviors:

Indesign - Mac:

  • Styles inverted (Regular = Medium, Bold = Regular, Weight = Bold)
  • Style linking: works but with inverted styles
  • Slider has inverted styles
Screenshot 2024-09-20 at 11 00 16 Screenshot 2024-09-20 at 11 00 22 Screenshot 2024-09-20 at 11 00 27 _____

Word - Mac:

  • style linking ok
  • 2 regulars
  • When I click on 'Medium', it doesn't work and it still stays selected on 'Regular'
  • When I click on 'SemiBold', it doesn't work and it still stays selected on 'Bold'
Screenshot 2024-09-20 at 11 03 06

Word - Windows:

  • 2 regulars in the menus
  • Bold works well with style linking
  • No SemiBold or Medium
Screenshot 2024-09-20 at 10 57 00

@simoncozens
Copy link
Collaborator Author

All of these URL are the same.

Look at the "h" in Hand...

@simoncozens
Copy link
Collaborator Author

The shaping issues could actually be to do with something else I am looking at right now. (I love it when that happens!)

When we use hb-subset to cut an instance from a variable font, the OS/2 fsSelection and macStyle bits are not set correctly for bold instances. This will cause the style linking problems you're seeing. We need a gftools-cut-instance which fixes the font after subsetting.

@emmamarichal
Copy link
Collaborator

emmamarichal commented Sep 20, 2024

Look at the "h" in Hand...

Oh yes sorry, I just opened the links to check, I didn't see caps!

Oh ok I see! thank you 🙏

@vv-monsalve vv-monsalve added the -- Needs Upstream Resolution Upstream fix required before moving forward label Sep 26, 2024

This comment was marked as outdated.

Copy link

FontBakery report

fontbakery version: 0.13.0a1

Check results

[22] EduAUVICWANTArrowsGuides[wght].ttf
🔥 FAIL MaxAdvanceWidth is consistent with values in the Hmtx and Hhea tables?
  • 🔥 FAIL

    AdvanceWidthMax mismatch: expected 2337 (from hmtx); got 2586 (from hhea)


    [code: mismatch]
🔥 FAIL Checking correctness of monospaced metadata.
  • 🔥 FAIL

    Value of hhea.advanceWidthMax should be set to 2337 but got 2586 instead.


    [code: bad-advanceWidthMax]
🔥 FAIL Combined length of family and style must not exceed 32 characters.
  • 🔥 FAIL

    Variable font instance name 'Edu AU VIC WA NT Arrows Guides Regular' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 276 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long]
  • 🔥 FAIL

    Variable font instance name 'Edu AU VIC WA NT Arrows Guides Medium' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 278 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long]
  • 🔥 FAIL

    Variable font instance name 'Edu AU VIC WA NT Arrows Guides SemiBold' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 280 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long]
  • 🔥 FAIL

    Variable font instance name 'Edu AU VIC WA NT Arrows Guides Bold' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 282 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long]
  • ⚠️ WARN

    Name ID 6 'EduAUVICWANTArrowsGuides-Regular' exceeds 27 characters. This has been found to cause problems with PostScript printers, especially on Mac platforms.


    [code: nameid6-too-long]
🔥 FAIL Whitespace glyphs have ink?
  • 🔥 FAIL

    Glyph 'space' has ink. It needs to be replaced by an empty glyph.


    [code: has-ink]

  • 🔥 FAIL

    Glyph 'uni00A0' has ink. It needs to be replaced by an empty glyph.


    [code: has-ink]

🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.
🔥 FAIL Shapes languages in all GF glyphsets.
  • 🔥 FAIL

    No GF glyphset was found to be supported >80%, so language shaping support couldn't get checked.


    [code: no-glyphset-supported]
🔥 FAIL Check Google Fonts glyph coverage.
  • 🔥 FAIL

    Missing required codepoints:

- 0x0021 (EXCLAMATION MARK)


- 0x0022 (QUOTATION MARK)


- 0x0023 (NUMBER SIGN)


- 0x0024 (DOLLAR SIGN)


- 0x0025 (PERCENT SIGN)


- 0x0026 (AMPERSAND)


- 0x0027 (APOSTROPHE)


- 0x0028 (LEFT PARENTHESIS)


- 0x0029 (RIGHT PARENTHESIS)


- 0x002A (ASTERISK)


- 245 more.

Use -F or --full-lists to disable shortening of long lists.

[code: missing-codepoints]
⚠️ WARN Font has correct post table version?
  • ⚠️ WARN

    Post table format 3 use has niche use case problems.Please review the check rationale for additional details.


    [code: post-table-version]
⚠️ WARN Check if OS/2 xAvgCharWidth is correct.
  • ⚠️ WARN

    OS/2 xAvgCharWidth is 1129 but it should be 1179 which corresponds to the average of the widths of all glyphs in the font.


    [code: xAvgCharWidth-wrong]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Family metadata at ofl/eduauvicwantarrowsguides does not have an article.


    [code: lacks-article]
⚠️ WARN Are there any misaligned on-curve points?
  • ⚠️ WARN

    The following glyphs have on-curve points which have potentially incorrect y coordinates:

* J (U+004A): X=-0.5,Y=2.0 (should be at baseline 0?)

* J (U+004A): X=-0.5,Y=2.0 (should be at baseline 0?)

* K (U+004B): X=1495.0,Y=1848.5 (should be at cap-height 1847?)

* K (U+004B): X=1495.0,Y=1848.5 (should be at cap-height 1847?)

* Q (U+0051): X=718.0,Y=-1.0 (should be at baseline 0?)

* Q (U+0051): X=718.0,Y=-1.0 (should be at baseline 0?)

* V (U+0056): X=1320.5,Y=1845.0 (should be at cap-height 1847?)

* V (U+0056): X=1320.5,Y=1845.0 (should be at cap-height 1847?)

* W (U+0057): X=2273.5,Y=1845.0 (should be at cap-height 1847?)

* W (U+0057): X=2273.5,Y=1845.0 (should be at cap-height 1847?)

* 48 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-misalignments]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
⚠️ WARN Check font follows the Google Fonts vertical metric schema
  • ⚠️ WARN

    We recommend the absolute sum of the hhea metrics should be between 1.2-1.5x of the font's upm. This font has 1.7395x (3479)


    [code: bad-hhea-range]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/eduauvicwantarrowsguides


    [code: family-path]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/eduauvicwantarrowsguides/EduAUVICWANTArrowsGuides[wght].ttf
Dehinted Size 101.3kb
Hinted Size 101.4kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- GSUB

- gasp

- vhea

- vmtx

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO Does DESCRIPTION file contain a upstream Git repo URL?
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
  • ℹ️ INFO

    This font doesn't have an ARTICLE.en_us.html file.


    [code: missing-article]
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 1.001']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 1)

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 7 6 53 10 177 0
0% 0% 3% 2% 21% 4% 70% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@vv-monsalve
Copy link
Collaborator

We need a gftools-cut-instance which fixes the font after subsetting.

Please ping us when you have updated the PR :)

@simoncozens
Copy link
Collaborator Author

@emmamarichal Just to confirm, were you testing the static or the variable font?

@emmamarichal
Copy link
Collaborator

@simoncozens the variable font!

@simoncozens
Copy link
Collaborator Author

Oh, OK. So it's probably a STAT table problem and I will stop messing about with static file instance cutting. :-)

@emmamarichal emmamarichal linked an issue Oct 11, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-- Needs Upstream Resolution Upstream fix required before moving forward I New Font
Projects
Status: PR GF
Development

Successfully merging this pull request may close these issues.

Add Edu VIC WA NT Arrows Guide
4 participants