Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Josefin Slab: Version 2.100 added #8206

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

emmamarichal
Copy link
Collaborator

@emmamarichal emmamarichal commented Sep 26, 2024

Taken from the upstream repo https://github.com/googlefonts/josefinslab at commit googlefonts/josefinslab@6d12a1c.

PR Checklist:

  • minisite_url definition in the METADATA.pb file for commissioned projects
  • primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target
  • subsets definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsets chinese-hongkong, chinese-simplified, chinese-traditional, korean, japanese.
  • Fontbakery checks are reviewed and failing checks are resolved in collaboration with the upstream font development team
  • Diffenator2 regression checks for revisions on all projects that are currently in production
  • Designers bio info have to be present in the designer catalog (at least an issue should be opened for tracking this, if they are not)
  • Check designers order in metadata.pb, since the first one of the list appears as “principal designer”
  • Social media formatted visual assets for all new commissioned projects in the Drive directory, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet
  • Social media content draft for all new commissioned projects in the Drive directory and Social Media tracker spreadsheet, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet

@emmamarichal emmamarichal linked an issue Sep 26, 2024 that may be closed by this pull request
Copy link

FontBakery report

fontbakery version: 0.13.0a1

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[1] JosefinSlab[wght].ttf
⚠️ WARN Checking that the typoAscender exceeds the yMax of the /Agrave.
  • ⚠️ WARN

    OS/2.sTypoAscender value should be greater than 883, but got 750 instead


    [code: typoAscender]
[1] JosefinSlab-Italic[wght].ttf
⚠️ WARN Checking that the typoAscender exceeds the yMax of the /Agrave.
  • ⚠️ WARN

    OS/2.sTypoAscender value should be greater than 883, but got 750 instead


    [code: typoAscender]

All other checks

[34] JosefinSlab-Italic[wght].ttf
🔥 FAIL STAT table has Axis Value tables?
  • 🔥 FAIL

    STAT table has no Axis Value tables.


    [code: no-axis-value-tables]
🔥 FAIL Font contains '.notdef' as its first glyph?
  • 🔥 FAIL

    The '.notdef' glyph should contain a drawing, but it is blank.


    [code: notdef-is-blank]
🔥 FAIL Ensure smart dropout control is enabled in "prep" table instructions.
  • 🔥 FAIL

    The 'prep' table does not contain TrueType instructions enabling smart dropout control. To fix, export the font with autohinting enabled, or run ttfautohint on the font, or run the gftools fix-nonhinting script.


    [code: lacks-smart-dropout]
🔥 FAIL Check name ID 25 to end with "Italic" for Italic VFs.
  • 🔥 FAIL

    Name ID 25 must end with "Italic" for Italic fonts.


    [code: nameid25-missing-italic]
🔥 FAIL Shapes languages in all GF glyphsets.
  • 🔥 FAIL

    No GF glyphset was found to be supported >80%, so language shaping support couldn't get checked.


    [code: no-glyphset-supported]
🔥 FAIL Does DESCRIPTION file contain a upstream Git repo URL?
  • 🔥 FAIL

    Please host your font project on a public Git repo (such as GitHub or GitLab) and place a link in the DESCRIPTION.en_us.html file.


    [code: lacks-git-url]
🔥 FAIL Name table strings must not contain the string 'Reserved Font Name'.

This is an error except in a few specific rare cases.

[code: rfn]
🔥 FAIL Check variable font instances
  • 🔥 FAIL

    fvar instances are incorrect:

  • Add missing instances
Name current expected
Thin Italic wght=100.0 wght=100.0
ExtraLight Italic N/A wght=200.0
Light Italic wght=300.0 wght=300.0
Italic wght=400.0 wght=400.0
Medium Italic N/A wght=500.0
SemiBold Italic wght=600.0 wght=600.0
Bold Italic wght=700.0 wght=700.0
[code: bad-fvar-instances]
🔥 FAIL Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • 🔥 FAIL

    Font is missing the 'gasp' table. Try exporting the font with autohinting enabled.
    If you are dealing with an unhinted font, it can be fixed by running the fonts through the command 'gftools fix-nonhinting'
    GFTools is available at https://pypi.org/project/gftools/


    [code: lacks-gasp]
🔥 FAIL Check Google Fonts glyph coverage.
  • 🔥 FAIL

    Missing required codepoints:

- 0x0100 (LATIN CAPITAL LETTER A WITH MACRON)


- 0x0101 (LATIN SMALL LETTER A WITH MACRON)


- 0x0102 (LATIN CAPITAL LETTER A WITH BREVE)


- 0x0103 (LATIN SMALL LETTER A WITH BREVE)


- 0x0104 (LATIN CAPITAL LETTER A WITH OGONEK)


- 0x0105 (LATIN SMALL LETTER A WITH OGONEK)


- 0x0106 (LATIN CAPITAL LETTER C WITH ACUTE)


- 0x0107 (LATIN SMALL LETTER C WITH ACUTE)


- 0x010A (LATIN CAPITAL LETTER C WITH DOT ABOVE)


- 0x010B (LATIN SMALL LETTER C WITH DOT ABOVE)


- 110 more.

Use -F or --full-lists to disable shortening of long lists.

[code: missing-codepoints]
🔥 FAIL Validate STAT particle names and values match the fallback names in GFAxisRegistry.
  • 🔥 FAIL

    STAT table is missing Axis Value Records


    [code: missing-axis-values]
⚠️ WARN Check hhea.caretSlopeRise and hhea.caretSlopeRun
  • ⚠️ WARN

    hhea.caretSlopeRise and hhea.caretSlopeRun do not match with post.italicAngle.
    Got: caretSlopeRise 1 and caretSlopeRun 0
    Expected: caretSlopeRise 1000 and caretSlopeRun 213


    [code: caretslope-mismatch]
⚠️ WARN Detect any interpolation issues in the font.
  • ⚠️ WARN

    Interpolation issues were found in the font:

- Contour 0 start point differs in glyph 'section' between location wght=100 and location wght=700

- Contour 0 in glyph 'section': becomes underweight between wght=100 and wght=700.

[code: interpolation-issues]

⚠️ WARN Check math signs have the same width.
  • ⚠️ WARN

    The most common width is 543 among a set of 1 math glyphs.
    The following math glyphs have a different width, though:

Width = 680: less

Width = 708: equal

Width = 650: greater

Width = 559: logicalnot

Width = 524: plusminus

Width = 500: multiply

Width = 501: divide

Width = 523: minus

[code: width-outliers]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Family metadata at ofl/josefinslab does not have an article.


    [code: lacks-article]
⚠️ WARN Copyright notice on METADATA.pb should not contain 'Reserved Font Name'.
  • ⚠️ WARN

    METADATA.pb: copyright field ("Copyright 2020 The Josefin Slab Project Authors (https://github.com/googlefonts/josefinslab/), with Reserved Font Name Josefin.") contains "Reserved Font Name". This is an error except in a few specific rare cases.


    [code: rfn]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+2074 SUPERSCRIPT FOUR: try adding math

Or you can add the above codepoints to one of the subsets supported by the font: latin, menu

[code: unreachable-subsetting]
⚠️ WARN DESCRIPTION.en_us.html should end in a linebreak.
  • ⚠️ WARN

    The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it.


    [code: missing-eof-linebreak]
⚠️ WARN On a family update, the DESCRIPTION.en_us.html file should ideally also be updated.
  • ⚠️ WARN

    The DESCRIPTION.en_us.html file in this family has not changed in comparison to the latest font release on the google/fonts github repo.
    Please consider mentioning note-worthy improvements made to the family recently.


    [code: description-not-updated]
⚠️ WARN Check copyright namerecords match license file.
⚠️ WARN License URL matches License text on name table?
  • ⚠️ WARN

    Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13]


    [code: http-in-description]

  • ⚠️ WARN

    Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13]


    [code: http-in-description]

  • ⚠️ WARN

    Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13]


    [code: http-in-description]

⚠️ WARN Check OFL body text is correct.

Lines changed:

+ Copyright (c) 2010, Santiago Orozco ([email protected]), with Reserved Font Name Josefin.\n

[code: incorrect-ofl-body-text]
⚠️ WARN Are there any misaligned on-curve points?
  • ⚠️ WARN

    The following glyphs have on-curve points which have potentially incorrect y coordinates:

* J (U+004A): X=152.5,Y=2.0 (should be at baseline 0?)

* N (U+004E): X=716.0,Y=2.0 (should be at baseline 0?)

* S (U+0053): X=373.0,Y=702.0 (should be at cap-height 700?)

* a (U+0061): X=340.5,Y=374.0 (should be at x-height 375?)

* e (U+0065): X=339.5,Y=373.0 (should be at x-height 375?)

* g (U+0067): X=344.5,Y=374.0 (should be at x-height 375?)

* r (U+0072): X=289.5,Y=373.5 (should be at x-height 375?)

* s (U+0073): X=107.5,Y=0.5 (should be at baseline 0?)

* s (U+0073): X=222.5,Y=2.0 (should be at baseline 0?)

* s (U+0073): X=263.0,Y=376.0 (should be at x-height 375?)

* 17 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-misalignments]
⚠️ WARN Check the direction of the outermost contour in each glyph
  • ⚠️ WARN

    The following glyphs have a counter-clockwise outer contour:

* A (U+0041) has a counter-clockwise outer contour

* AE (U+00C6) has a counter-clockwise outer contour

* Aacute (U+00C1) has a counter-clockwise outer contour

* Aacute (U+00C1) has a counter-clockwise outer contour

* Acircumflex (U+00C2) has a counter-clockwise outer contour

* Acircumflex (U+00C2) has a counter-clockwise outer contour

* Adieresis (U+00C4) has a counter-clockwise outer contour

* Adieresis (U+00C4) has a counter-clockwise outer contour

* Adieresis (U+00C4) has a counter-clockwise outer contour

* Agrave (U+00C0) has a counter-clockwise outer contour

* 292 more.

Use -F or --full-lists to disable shortening of long lists.

[code: ccw-outer-contour]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
⚠️ WARN Checking OS/2 achVendID.
  • ⚠️ WARN

    OS/2 VendorID value ' GOO' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx


    [code: unknown]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/josefinslab


    [code: family-path]
ℹ️ INFO Familyname must be unique according to namecheck.fontdata.com
  • ℹ️ INFO

    The family name "JosefinSlab" seems to be already in use.
    Please visit http://namecheck.fontdata.com for more info.


    [code: name-collision]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/josefinslab/JosefinSlab-Italic[wght].ttf
Dehinted Size 42.9kb
Hinted Size 42.9kb
Increase -24 bytes
Change -0.1 %
[code: size-impact]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- GPOS

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
  • ℹ️ INFO

    This font doesn't have an ARTICLE.en_us.html file.


    [code: missing-article]
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.100']


    [code: version-not-detected]
[2] Family checks
🔥 FAIL Ensure VFs have 'ital' STAT axis.
  • 🔥 FAIL

    Font JosefinSlab[wght].ttf is missing an 'ital' axis.


    [code: missing-ital-axis]

  • 🔥 FAIL

    Font JosefinSlab-Italic[wght].ttf is missing an 'ital' axis.


    [code: missing-ital-axis]

ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 2)

[code: summary]

[29] JosefinSlab[wght].ttf
🔥 FAIL STAT table has Axis Value tables?
  • 🔥 FAIL

    STAT table has no Axis Value tables.


    [code: no-axis-value-tables]
🔥 FAIL Font contains '.notdef' as its first glyph?
  • 🔥 FAIL

    The '.notdef' glyph should contain a drawing, but it is blank.


    [code: notdef-is-blank]
🔥 FAIL Ensure smart dropout control is enabled in "prep" table instructions.
  • 🔥 FAIL

    The 'prep' table does not contain TrueType instructions enabling smart dropout control. To fix, export the font with autohinting enabled, or run ttfautohint on the font, or run the gftools fix-nonhinting script.


    [code: lacks-smart-dropout]
🔥 FAIL Ensure component transforms do not perform scaling or rotation.
  • 🔥 FAIL

    The following glyphs had components with scaling or rotation
    or inverted outline direction:

  • exclamdown (component exclam)
  • guillemotright (component guillemotleft)
  • guilsinglright (component guilsinglleft)
[code: transformed-components]
🔥 FAIL Shapes languages in all GF glyphsets.
  • 🔥 FAIL

    No GF glyphset was found to be supported >80%, so language shaping support couldn't get checked.


    [code: no-glyphset-supported]
🔥 FAIL Does DESCRIPTION file contain a upstream Git repo URL?
  • 🔥 FAIL

    Please host your font project on a public Git repo (such as GitHub or GitLab) and place a link in the DESCRIPTION.en_us.html file.


    [code: lacks-git-url]
🔥 FAIL Name table strings must not contain the string 'Reserved Font Name'.

This is an error except in a few specific rare cases.

[code: rfn]
🔥 FAIL Check variable font instances
  • 🔥 FAIL

    fvar instances are incorrect:

  • Add missing instances
Name current expected
Thin wght=100.0 wght=100.0
ExtraLight N/A wght=200.0
Light wght=300.0 wght=300.0
Regular wght=400.0 wght=400.0
Medium N/A wght=500.0
SemiBold wght=600.0 wght=600.0
Bold wght=700.0 wght=700.0
[code: bad-fvar-instances]
🔥 FAIL Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • 🔥 FAIL

    Font is missing the 'gasp' table. Try exporting the font with autohinting enabled.
    If you are dealing with an unhinted font, it can be fixed by running the fonts through the command 'gftools fix-nonhinting'
    GFTools is available at https://pypi.org/project/gftools/


    [code: lacks-gasp]
🔥 FAIL Check Google Fonts glyph coverage.
  • 🔥 FAIL

    Missing required codepoints:

- 0x0100 (LATIN CAPITAL LETTER A WITH MACRON)


- 0x0101 (LATIN SMALL LETTER A WITH MACRON)


- 0x0102 (LATIN CAPITAL LETTER A WITH BREVE)


- 0x0103 (LATIN SMALL LETTER A WITH BREVE)


- 0x0104 (LATIN CAPITAL LETTER A WITH OGONEK)


- 0x0105 (LATIN SMALL LETTER A WITH OGONEK)


- 0x0106 (LATIN CAPITAL LETTER C WITH ACUTE)


- 0x0107 (LATIN SMALL LETTER C WITH ACUTE)


- 0x010A (LATIN CAPITAL LETTER C WITH DOT ABOVE)


- 0x010B (LATIN SMALL LETTER C WITH DOT ABOVE)


- 110 more.

Use -F or --full-lists to disable shortening of long lists.

[code: missing-codepoints]
🔥 FAIL Validate STAT particle names and values match the fallback names in GFAxisRegistry.
  • 🔥 FAIL

    STAT table is missing Axis Value Records


    [code: missing-axis-values]
⚠️ WARN Detect any interpolation issues in the font.
  • ⚠️ WARN

    Interpolation issues were found in the font:

- Contour 0 start point differs in glyph 'at' between location wght=100 and location wght=700

- Contour 0 in glyph 'at': becomes underweight between wght=100 and wght=700.

- Contour 0 start point differs in glyph 'percent' between location wght=100 and location wght=700

- Contour 2 start point differs in glyph 'percent' between location wght=100 and location wght=700

- Contour 0 start point differs in glyph 'eight' between location wght=100 and location wght=700

- Contour 0 in glyph 'eight': becomes underweight between wght=100 and wght=700.

- Contour 0 start point differs in glyph 'section' between location wght=100 and location wght=700

- Contour 0 in glyph 'section': becomes underweight between wght=100 and wght=700.

[code: interpolation-issues]

⚠️ WARN Check math signs have the same width.
  • ⚠️ WARN

    The most common width is 524 among a set of 2 math glyphs.
    The following math glyphs have a different width, though:

Width = 543: plus

Width = 680: less

Width = 708: equal

Width = 650: greater

Width = 559: logicalnot

Width = 500: multiply

Width = 501: divide

[code: width-outliers]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Family metadata at ofl/josefinslab does not have an article.


    [code: lacks-article]
⚠️ WARN Copyright notice on METADATA.pb should not contain 'Reserved Font Name'.
  • ⚠️ WARN

    METADATA.pb: copyright field ("Copyright 2020 The Josefin Slab Project Authors (https://github.com/googlefonts/josefinslab/), with Reserved Font Name Josefin.") contains "Reserved Font Name". This is an error except in a few specific rare cases.


    [code: rfn]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+2074 SUPERSCRIPT FOUR: try adding math

Or you can add the above codepoints to one of the subsets supported by the font: latin, menu

[code: unreachable-subsetting]
⚠️ WARN DESCRIPTION.en_us.html should end in a linebreak.
  • ⚠️ WARN

    The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it.


    [code: missing-eof-linebreak]
⚠️ WARN Check OFL body text is correct.

Lines changed:

+ Copyright (c) 2010, Santiago Orozco ([email protected]), with Reserved Font Name Josefin.\n

[code: incorrect-ofl-body-text]
⚠️ WARN Are there any misaligned on-curve points?
  • ⚠️ WARN

    The following glyphs have on-curve points which have potentially incorrect y coordinates:

* Atilde (U+00C3): X=474.0,Y=752.0 (should be at ascender 750?)

* J (U+004A): X=193.0,Y=2.0 (should be at baseline 0?)

* N (U+004E): X=712.0,Y=2.0 (should be at baseline 0?)

* Ntilde (U+00D1): X=712.0,Y=2.0 (should be at baseline 0?)

* Ntilde (U+00D1): X=472.0,Y=752.0 (should be at ascender 750?)

* Otilde (U+00D5): X=459.0,Y=752.0 (should be at ascender 750?)

* OE (U+0152): X=845.0,Y=701.0 (should be at cap-height 700?)

* S (U+0053): X=297.5,Y=702.0 (should be at cap-height 700?)

* b (U+0062): X=243.5,Y=374.0 (should be at x-height 375?)

* d (U+0064): X=288.5,Y=374.0 (should be at x-height 375?)

* 17 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-misalignments]
⚠️ WARN Check the direction of the outermost contour in each glyph
  • ⚠️ WARN

    The following glyphs have a counter-clockwise outer contour:

* A (U+0041) has a counter-clockwise outer contour

* AE (U+00C6) has a counter-clockwise outer contour

* Aacute (U+00C1) has a counter-clockwise outer contour

* Aacute (U+00C1) has a counter-clockwise outer contour

* Acircumflex (U+00C2) has a counter-clockwise outer contour

* Acircumflex (U+00C2) has a counter-clockwise outer contour

* Adieresis (U+00C4) has a counter-clockwise outer contour

* Adieresis (U+00C4) has a counter-clockwise outer contour

* Adieresis (U+00C4) has a counter-clockwise outer contour

* Agrave (U+00C0) has a counter-clockwise outer contour

* 288 more.

Use -F or --full-lists to disable shortening of long lists.

[code: ccw-outer-contour]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/josefinslab


    [code: family-path]
ℹ️ INFO Familyname must be unique according to namecheck.fontdata.com
  • ℹ️ INFO

    The family name "JosefinSlab" seems to be already in use.
    Please visit http://namecheck.fontdata.com for more info.


    [code: name-collision]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/josefinslab/JosefinSlab[wght].ttf
Dehinted Size 40.4kb
Hinted Size 40.4kb
Increase -24 bytes
Change -0.1 %
[code: size-impact]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- GPOS

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
  • ℹ️ INFO

    This font doesn't have an ARTICLE.en_us.html file.


    [code: missing-article]
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.100']


    [code: version-not-detected]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 23 27 97 17 324 0
0% 0% 5% 6% 20% 3% 66% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@vv-monsalve
Copy link
Collaborator

vv-monsalve commented Sep 26, 2024

@emmamarichal note for this PR: Many fails remain because the idea was to quickly fix the kerning issues. Since there are UFOs, updating them would require a lot of work, so this PR only what Dave marked as a priority for now.

@vv-monsalve
Copy link
Collaborator

@emmamarichal some kerning pairs still need to be improved, e.g. some combinations with lower case letters
Screenshot 2024-09-26 at 11 58 07

@emmamarichal
Copy link
Collaborator Author

Updated

Copy link

FontBakery report

fontbakery version: 0.13.0a1

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[1] JosefinSlab[wght].ttf
⚠️ WARN Checking that the typoAscender exceeds the yMax of the /Agrave.
  • ⚠️ WARN

    OS/2.sTypoAscender value should be greater than 883, but got 750 instead


    [code: typoAscender]
[1] JosefinSlab-Italic[wght].ttf
⚠️ WARN Checking that the typoAscender exceeds the yMax of the /Agrave.
  • ⚠️ WARN

    OS/2.sTypoAscender value should be greater than 883, but got 750 instead


    [code: typoAscender]

All other checks

[36] JosefinSlab-Italic[wght].ttf
🔥 FAIL STAT table has Axis Value tables?
  • 🔥 FAIL

    STAT table has no Axis Value tables.


    [code: no-axis-value-tables]
🔥 FAIL Font contains '.notdef' as its first glyph?
  • 🔥 FAIL

    The '.notdef' glyph should contain a drawing, but it is blank.


    [code: notdef-is-blank]
🔥 FAIL Ensure smart dropout control is enabled in "prep" table instructions.
  • 🔥 FAIL

    The 'prep' table does not contain TrueType instructions enabling smart dropout control. To fix, export the font with autohinting enabled, or run ttfautohint on the font, or run the gftools fix-nonhinting script.


    [code: lacks-smart-dropout]
🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.

But: font copyright string has 'https://github.com/googlefonts/josefinslab', font copyright string has 'https://github.com/googlefonts/josefinslab' and OFL text has 'https://github.com/googlefonts/josefinslab'

[code: mismatch]
🔥 FAIL Check name ID 25 to end with "Italic" for Italic VFs.
  • 🔥 FAIL

    Name ID 25 must end with "Italic" for Italic fonts.


    [code: nameid25-missing-italic]
🔥 FAIL Shapes languages in all GF glyphsets.
  • 🔥 FAIL

    No GF glyphset was found to be supported >80%, so language shaping support couldn't get checked.


    [code: no-glyphset-supported]
🔥 FAIL Does DESCRIPTION file contain a upstream Git repo URL?
  • 🔥 FAIL

    Please host your font project on a public Git repo (such as GitHub or GitLab) and place a link in the DESCRIPTION.en_us.html file.


    [code: lacks-git-url]
🔥 FAIL Name table strings must not contain the string 'Reserved Font Name'.

This is an error except in a few specific rare cases.

[code: rfn]
🔥 FAIL Check variable font instances
  • 🔥 FAIL

    fvar instances are incorrect:

  • Add missing instances
Name current expected
Thin Italic wght=100.0 wght=100.0
ExtraLight Italic N/A wght=200.0
Light Italic wght=300.0 wght=300.0
Italic wght=400.0 wght=400.0
Medium Italic N/A wght=500.0
SemiBold Italic wght=600.0 wght=600.0
Bold Italic wght=700.0 wght=700.0
[code: bad-fvar-instances]
🔥 FAIL Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • 🔥 FAIL

    Font is missing the 'gasp' table. Try exporting the font with autohinting enabled.
    If you are dealing with an unhinted font, it can be fixed by running the fonts through the command 'gftools fix-nonhinting'
    GFTools is available at https://pypi.org/project/gftools/


    [code: lacks-gasp]
🔥 FAIL Check Google Fonts glyph coverage.
  • 🔥 FAIL

    Missing required codepoints:

- 0x0100 (LATIN CAPITAL LETTER A WITH MACRON)


- 0x0101 (LATIN SMALL LETTER A WITH MACRON)


- 0x0102 (LATIN CAPITAL LETTER A WITH BREVE)


- 0x0103 (LATIN SMALL LETTER A WITH BREVE)


- 0x0104 (LATIN CAPITAL LETTER A WITH OGONEK)


- 0x0105 (LATIN SMALL LETTER A WITH OGONEK)


- 0x0106 (LATIN CAPITAL LETTER C WITH ACUTE)


- 0x0107 (LATIN SMALL LETTER C WITH ACUTE)


- 0x010A (LATIN CAPITAL LETTER C WITH DOT ABOVE)


- 0x010B (LATIN SMALL LETTER C WITH DOT ABOVE)


- 110 more.

Use -F or --full-lists to disable shortening of long lists.

[code: missing-codepoints]
🔥 FAIL Validate STAT particle names and values match the fallback names in GFAxisRegistry.
  • 🔥 FAIL

    STAT table is missing Axis Value Records


    [code: missing-axis-values]
⚠️ WARN Check hhea.caretSlopeRise and hhea.caretSlopeRun
  • ⚠️ WARN

    hhea.caretSlopeRise and hhea.caretSlopeRun do not match with post.italicAngle.
    Got: caretSlopeRise 1 and caretSlopeRun 0
    Expected: caretSlopeRise 1000 and caretSlopeRun 213


    [code: caretslope-mismatch]
⚠️ WARN Detect any interpolation issues in the font.
  • ⚠️ WARN

    Interpolation issues were found in the font:

- Contour 0 start point differs in glyph 'section' between location wght=100 and location wght=700

- Contour 0 in glyph 'section': becomes underweight between wght=100 and wght=700.

[code: interpolation-issues]

⚠️ WARN Check math signs have the same width.
  • ⚠️ WARN

    The most common width is 543 among a set of 1 math glyphs.
    The following math glyphs have a different width, though:

Width = 680: less

Width = 708: equal

Width = 650: greater

Width = 559: logicalnot

Width = 524: plusminus

Width = 500: multiply

Width = 501: divide

Width = 523: minus

[code: width-outliers]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Family metadata at ofl/josefinslab does not have an article.


    [code: lacks-article]
⚠️ WARN Copyright notice on METADATA.pb should not contain 'Reserved Font Name'.
  • ⚠️ WARN

    METADATA.pb: copyright field ("Copyright 2020 The Josefin Slab Project Authors (https://github.com/googlefonts/josefinslab/), with Reserved Font Name Josefin.") contains "Reserved Font Name". This is an error except in a few specific rare cases.


    [code: rfn]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+2074 SUPERSCRIPT FOUR: try adding math

Or you can add the above codepoints to one of the subsets supported by the font: latin, menu

[code: unreachable-subsetting]
⚠️ WARN DESCRIPTION.en_us.html should end in a linebreak.
  • ⚠️ WARN

    The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it.


    [code: missing-eof-linebreak]
⚠️ WARN On a family update, the DESCRIPTION.en_us.html file should ideally also be updated.
  • ⚠️ WARN

    The DESCRIPTION.en_us.html file in this family has not changed in comparison to the latest font release on the google/fonts github repo.
    Please consider mentioning note-worthy improvements made to the family recently.


    [code: description-not-updated]
⚠️ WARN Check copyright namerecords match license file.
⚠️ WARN License URL matches License text on name table?
  • ⚠️ WARN

    Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13]


    [code: http-in-description]

  • ⚠️ WARN

    Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13]


    [code: http-in-description]

  • ⚠️ WARN

    Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13]


    [code: http-in-description]

⚠️ WARN Check OFL body text is correct.

Lines changed:

+ Copyright (c) 2010, Santiago Orozco ([email protected]), with Reserved Font Name Josefin.\n

[code: incorrect-ofl-body-text]
⚠️ WARN A static fonts directory, if present, must contain manually hinted fonts
  • ⚠️ WARN

    There is a "static" dir but it contains fonts which are not manually hinted. Delete the directory.


    [code: not-manually-hinted]
⚠️ WARN Are there any misaligned on-curve points?
  • ⚠️ WARN

    The following glyphs have on-curve points which have potentially incorrect y coordinates:

* J (U+004A): X=152.5,Y=2.0 (should be at baseline 0?)

* N (U+004E): X=716.0,Y=2.0 (should be at baseline 0?)

* S (U+0053): X=373.0,Y=702.0 (should be at cap-height 700?)

* a (U+0061): X=340.5,Y=374.0 (should be at x-height 375?)

* e (U+0065): X=339.5,Y=373.0 (should be at x-height 375?)

* g (U+0067): X=344.5,Y=374.0 (should be at x-height 375?)

* r (U+0072): X=289.5,Y=373.5 (should be at x-height 375?)

* s (U+0073): X=87.5,Y=0.5 (should be at baseline 0?)

* s (U+0073): X=202.5,Y=2.0 (should be at baseline 0?)

* s (U+0073): X=243.0,Y=376.0 (should be at x-height 375?)

* 17 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-misalignments]
⚠️ WARN Check the direction of the outermost contour in each glyph
  • ⚠️ WARN

    The following glyphs have a counter-clockwise outer contour:

* A (U+0041) has a counter-clockwise outer contour

* AE (U+00C6) has a counter-clockwise outer contour

* Aacute (U+00C1) has a counter-clockwise outer contour

* Aacute (U+00C1) has a counter-clockwise outer contour

* Acircumflex (U+00C2) has a counter-clockwise outer contour

* Acircumflex (U+00C2) has a counter-clockwise outer contour

* Adieresis (U+00C4) has a counter-clockwise outer contour

* Adieresis (U+00C4) has a counter-clockwise outer contour

* Adieresis (U+00C4) has a counter-clockwise outer contour

* Agrave (U+00C0) has a counter-clockwise outer contour

* 292 more.

Use -F or --full-lists to disable shortening of long lists.

[code: ccw-outer-contour]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
⚠️ WARN Checking OS/2 achVendID.
  • ⚠️ WARN

    OS/2 VendorID value ' GOO' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx


    [code: unknown]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/josefinslab


    [code: family-path]
ℹ️ INFO Familyname must be unique according to namecheck.fontdata.com
  • ℹ️ INFO

    The family name "JosefinSlab" seems to be already in use.
    Please visit http://namecheck.fontdata.com for more info.


    [code: name-collision]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/josefinslab/JosefinSlab-Italic[wght].ttf
Dehinted Size 46.9kb
Hinted Size 46.9kb
Increase -24 bytes
Change -0.0 %
[code: size-impact]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- GPOS

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
  • ℹ️ INFO

    This font doesn't have an ARTICLE.en_us.html file.


    [code: missing-article]
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.100']


    [code: version-not-detected]
[2] Family checks
🔥 FAIL Ensure VFs have 'ital' STAT axis.
  • 🔥 FAIL

    Font JosefinSlab[wght].ttf is missing an 'ital' axis.


    [code: missing-ital-axis]

  • 🔥 FAIL

    Font JosefinSlab-Italic[wght].ttf is missing an 'ital' axis.


    [code: missing-ital-axis]

ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 2)

[code: summary]

[31] JosefinSlab[wght].ttf
🔥 FAIL STAT table has Axis Value tables?
  • 🔥 FAIL

    STAT table has no Axis Value tables.


    [code: no-axis-value-tables]
🔥 FAIL Font contains '.notdef' as its first glyph?
  • 🔥 FAIL

    The '.notdef' glyph should contain a drawing, but it is blank.


    [code: notdef-is-blank]
🔥 FAIL Ensure smart dropout control is enabled in "prep" table instructions.
  • 🔥 FAIL

    The 'prep' table does not contain TrueType instructions enabling smart dropout control. To fix, export the font with autohinting enabled, or run ttfautohint on the font, or run the gftools fix-nonhinting script.


    [code: lacks-smart-dropout]
🔥 FAIL Ensure component transforms do not perform scaling or rotation.
  • 🔥 FAIL

    The following glyphs had components with scaling or rotation
    or inverted outline direction:

  • exclamdown (component exclam)
  • guillemotright (component guillemotleft)
  • guilsinglright (component guilsinglleft)
[code: transformed-components]
🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.

But: font copyright string has 'https://github.com/googlefonts/josefinslab', font copyright string has 'https://github.com/googlefonts/josefinslab' and OFL text has 'https://github.com/googlefonts/josefinslab'

[code: mismatch]
🔥 FAIL Shapes languages in all GF glyphsets.
  • 🔥 FAIL

    No GF glyphset was found to be supported >80%, so language shaping support couldn't get checked.


    [code: no-glyphset-supported]
🔥 FAIL Does DESCRIPTION file contain a upstream Git repo URL?
  • 🔥 FAIL

    Please host your font project on a public Git repo (such as GitHub or GitLab) and place a link in the DESCRIPTION.en_us.html file.


    [code: lacks-git-url]
🔥 FAIL Name table strings must not contain the string 'Reserved Font Name'.

This is an error except in a few specific rare cases.

[code: rfn]
🔥 FAIL Check variable font instances
  • 🔥 FAIL

    fvar instances are incorrect:

  • Add missing instances
Name current expected
Thin wght=100.0 wght=100.0
ExtraLight N/A wght=200.0
Light wght=300.0 wght=300.0
Regular wght=400.0 wght=400.0
Medium N/A wght=500.0
SemiBold wght=600.0 wght=600.0
Bold wght=700.0 wght=700.0
[code: bad-fvar-instances]
🔥 FAIL Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • 🔥 FAIL

    Font is missing the 'gasp' table. Try exporting the font with autohinting enabled.
    If you are dealing with an unhinted font, it can be fixed by running the fonts through the command 'gftools fix-nonhinting'
    GFTools is available at https://pypi.org/project/gftools/


    [code: lacks-gasp]
🔥 FAIL Check Google Fonts glyph coverage.
  • 🔥 FAIL

    Missing required codepoints:

- 0x0100 (LATIN CAPITAL LETTER A WITH MACRON)


- 0x0101 (LATIN SMALL LETTER A WITH MACRON)


- 0x0102 (LATIN CAPITAL LETTER A WITH BREVE)


- 0x0103 (LATIN SMALL LETTER A WITH BREVE)


- 0x0104 (LATIN CAPITAL LETTER A WITH OGONEK)


- 0x0105 (LATIN SMALL LETTER A WITH OGONEK)


- 0x0106 (LATIN CAPITAL LETTER C WITH ACUTE)


- 0x0107 (LATIN SMALL LETTER C WITH ACUTE)


- 0x010A (LATIN CAPITAL LETTER C WITH DOT ABOVE)


- 0x010B (LATIN SMALL LETTER C WITH DOT ABOVE)


- 110 more.

Use -F or --full-lists to disable shortening of long lists.

[code: missing-codepoints]
🔥 FAIL Validate STAT particle names and values match the fallback names in GFAxisRegistry.
  • 🔥 FAIL

    STAT table is missing Axis Value Records


    [code: missing-axis-values]
⚠️ WARN Detect any interpolation issues in the font.
  • ⚠️ WARN

    Interpolation issues were found in the font:

- Contour 0 start point differs in glyph 'section' between location wght=100 and location wght=700

- Contour 0 in glyph 'section': becomes underweight between wght=100 and wght=700.

- Contour 0 start point differs in glyph 'at' between location wght=100 and location wght=700

- Contour 0 in glyph 'at': becomes underweight between wght=100 and wght=700.

- Contour 0 start point differs in glyph 'percent' between location wght=100 and location wght=700

- Contour 2 start point differs in glyph 'percent' between location wght=100 and location wght=700

- Contour 0 start point differs in glyph 'eight' between location wght=100 and location wght=700

- Contour 0 in glyph 'eight': becomes underweight between wght=100 and wght=700.

[code: interpolation-issues]

⚠️ WARN Check math signs have the same width.
  • ⚠️ WARN

    The most common width is 524 among a set of 2 math glyphs.
    The following math glyphs have a different width, though:

Width = 543: plus

Width = 680: less

Width = 708: equal

Width = 650: greater

Width = 559: logicalnot

Width = 500: multiply

Width = 501: divide

[code: width-outliers]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Family metadata at ofl/josefinslab does not have an article.


    [code: lacks-article]
⚠️ WARN Copyright notice on METADATA.pb should not contain 'Reserved Font Name'.
  • ⚠️ WARN

    METADATA.pb: copyright field ("Copyright 2020 The Josefin Slab Project Authors (https://github.com/googlefonts/josefinslab/), with Reserved Font Name Josefin.") contains "Reserved Font Name". This is an error except in a few specific rare cases.


    [code: rfn]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+2074 SUPERSCRIPT FOUR: try adding math

Or you can add the above codepoints to one of the subsets supported by the font: latin, menu

[code: unreachable-subsetting]
⚠️ WARN DESCRIPTION.en_us.html should end in a linebreak.
  • ⚠️ WARN

    The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it.


    [code: missing-eof-linebreak]
⚠️ WARN Check OFL body text is correct.

Lines changed:

+ Copyright (c) 2010, Santiago Orozco ([email protected]), with Reserved Font Name Josefin.\n

[code: incorrect-ofl-body-text]
⚠️ WARN A static fonts directory, if present, must contain manually hinted fonts
  • ⚠️ WARN

    There is a "static" dir but it contains fonts which are not manually hinted. Delete the directory.


    [code: not-manually-hinted]
⚠️ WARN Are there any misaligned on-curve points?
  • ⚠️ WARN

    The following glyphs have on-curve points which have potentially incorrect y coordinates:

* Atilde (U+00C3): X=474.0,Y=752.0 (should be at ascender 750?)

* J (U+004A): X=193.0,Y=2.0 (should be at baseline 0?)

* N (U+004E): X=712.0,Y=2.0 (should be at baseline 0?)

* Ntilde (U+00D1): X=712.0,Y=2.0 (should be at baseline 0?)

* Ntilde (U+00D1): X=472.0,Y=752.0 (should be at ascender 750?)

* Otilde (U+00D5): X=459.0,Y=752.0 (should be at ascender 750?)

* OE (U+0152): X=845.0,Y=701.0 (should be at cap-height 700?)

* S (U+0053): X=297.5,Y=702.0 (should be at cap-height 700?)

* b (U+0062): X=243.5,Y=374.0 (should be at x-height 375?)

* d (U+0064): X=288.5,Y=374.0 (should be at x-height 375?)

* 17 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-misalignments]
⚠️ WARN Check the direction of the outermost contour in each glyph
  • ⚠️ WARN

    The following glyphs have a counter-clockwise outer contour:

* A (U+0041) has a counter-clockwise outer contour

* AE (U+00C6) has a counter-clockwise outer contour

* Aacute (U+00C1) has a counter-clockwise outer contour

* Aacute (U+00C1) has a counter-clockwise outer contour

* Acircumflex (U+00C2) has a counter-clockwise outer contour

* Acircumflex (U+00C2) has a counter-clockwise outer contour

* Adieresis (U+00C4) has a counter-clockwise outer contour

* Adieresis (U+00C4) has a counter-clockwise outer contour

* Adieresis (U+00C4) has a counter-clockwise outer contour

* Agrave (U+00C0) has a counter-clockwise outer contour

* 288 more.

Use -F or --full-lists to disable shortening of long lists.

[code: ccw-outer-contour]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/josefinslab


    [code: family-path]
ℹ️ INFO Familyname must be unique according to namecheck.fontdata.com
  • ℹ️ INFO

    The family name "JosefinSlab" seems to be already in use.
    Please visit http://namecheck.fontdata.com for more info.


    [code: name-collision]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/josefinslab/JosefinSlab[wght].ttf
Dehinted Size 44.5kb
Hinted Size 44.5kb
Increase -24 bytes
Change -0.1 %
[code: size-impact]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- GPOS

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
  • ℹ️ INFO

    This font doesn't have an ARTICLE.en_us.html file.


    [code: missing-article]
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.100']


    [code: version-not-detected]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 25 29 97 17 320 0
0% 0% 5% 6% 20% 3% 66% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

Copy link

FontBakery report

fontbakery version: 0.13.0a1

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[1] JosefinSlab[wght].ttf
⚠️ WARN Checking that the typoAscender exceeds the yMax of the /Agrave.
  • ⚠️ WARN

    OS/2.sTypoAscender value should be greater than 883, but got 750 instead


    [code: typoAscender]
[1] JosefinSlab-Italic[wght].ttf
⚠️ WARN Checking that the typoAscender exceeds the yMax of the /Agrave.
  • ⚠️ WARN

    OS/2.sTypoAscender value should be greater than 883, but got 750 instead


    [code: typoAscender]

All other checks

[36] JosefinSlab-Italic[wght].ttf
🔥 FAIL STAT table has Axis Value tables?
  • 🔥 FAIL

    STAT table has no Axis Value tables.


    [code: no-axis-value-tables]
🔥 FAIL Font contains '.notdef' as its first glyph?
  • 🔥 FAIL

    The '.notdef' glyph should contain a drawing, but it is blank.


    [code: notdef-is-blank]
🔥 FAIL Ensure smart dropout control is enabled in "prep" table instructions.
  • 🔥 FAIL

    The 'prep' table does not contain TrueType instructions enabling smart dropout control. To fix, export the font with autohinting enabled, or run ttfautohint on the font, or run the gftools fix-nonhinting script.


    [code: lacks-smart-dropout]
🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.

But: font copyright string has 'https://github.com/googlefonts/josefinslab', font copyright string has 'https://github.com/googlefonts/josefinslab' and OFL text has 'https://github.com/googlefonts/josefinslab'

[code: mismatch]
🔥 FAIL Check name ID 25 to end with "Italic" for Italic VFs.
  • 🔥 FAIL

    Name ID 25 must end with "Italic" for Italic fonts.


    [code: nameid25-missing-italic]
🔥 FAIL Shapes languages in all GF glyphsets.
  • 🔥 FAIL

    No GF glyphset was found to be supported >80%, so language shaping support couldn't get checked.


    [code: no-glyphset-supported]
🔥 FAIL Does DESCRIPTION file contain a upstream Git repo URL?
  • 🔥 FAIL

    Please host your font project on a public Git repo (such as GitHub or GitLab) and place a link in the DESCRIPTION.en_us.html file.


    [code: lacks-git-url]
🔥 FAIL Name table strings must not contain the string 'Reserved Font Name'.

This is an error except in a few specific rare cases.

[code: rfn]
🔥 FAIL Check variable font instances
  • 🔥 FAIL

    fvar instances are incorrect:

  • Add missing instances
Name current expected
Thin Italic wght=100.0 wght=100.0
ExtraLight Italic N/A wght=200.0
Light Italic wght=300.0 wght=300.0
Italic wght=400.0 wght=400.0
Medium Italic N/A wght=500.0
SemiBold Italic wght=600.0 wght=600.0
Bold Italic wght=700.0 wght=700.0
[code: bad-fvar-instances]
🔥 FAIL Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • 🔥 FAIL

    Font is missing the 'gasp' table. Try exporting the font with autohinting enabled.
    If you are dealing with an unhinted font, it can be fixed by running the fonts through the command 'gftools fix-nonhinting'
    GFTools is available at https://pypi.org/project/gftools/


    [code: lacks-gasp]
🔥 FAIL Check Google Fonts glyph coverage.
  • 🔥 FAIL

    Missing required codepoints:

- 0x0100 (LATIN CAPITAL LETTER A WITH MACRON)


- 0x0101 (LATIN SMALL LETTER A WITH MACRON)


- 0x0102 (LATIN CAPITAL LETTER A WITH BREVE)


- 0x0103 (LATIN SMALL LETTER A WITH BREVE)


- 0x0104 (LATIN CAPITAL LETTER A WITH OGONEK)


- 0x0105 (LATIN SMALL LETTER A WITH OGONEK)


- 0x0106 (LATIN CAPITAL LETTER C WITH ACUTE)


- 0x0107 (LATIN SMALL LETTER C WITH ACUTE)


- 0x010A (LATIN CAPITAL LETTER C WITH DOT ABOVE)


- 0x010B (LATIN SMALL LETTER C WITH DOT ABOVE)


- 110 more.

Use -F or --full-lists to disable shortening of long lists.

[code: missing-codepoints]
🔥 FAIL Validate STAT particle names and values match the fallback names in GFAxisRegistry.
  • 🔥 FAIL

    STAT table is missing Axis Value Records


    [code: missing-axis-values]
⚠️ WARN Check hhea.caretSlopeRise and hhea.caretSlopeRun
  • ⚠️ WARN

    hhea.caretSlopeRise and hhea.caretSlopeRun do not match with post.italicAngle.
    Got: caretSlopeRise 1 and caretSlopeRun 0
    Expected: caretSlopeRise 1000 and caretSlopeRun 213


    [code: caretslope-mismatch]
⚠️ WARN Detect any interpolation issues in the font.
  • ⚠️ WARN

    Interpolation issues were found in the font:

- Contour 0 start point differs in glyph 'section' between location wght=100 and location wght=700

- Contour 0 in glyph 'section': becomes underweight between wght=100 and wght=700.

[code: interpolation-issues]

⚠️ WARN Check math signs have the same width.
  • ⚠️ WARN

    The most common width is 543 among a set of 1 math glyphs.
    The following math glyphs have a different width, though:

Width = 680: less

Width = 708: equal

Width = 650: greater

Width = 559: logicalnot

Width = 524: plusminus

Width = 500: multiply

Width = 501: divide

Width = 523: minus

[code: width-outliers]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Family metadata at ofl/josefinslab does not have an article.


    [code: lacks-article]
⚠️ WARN Copyright notice on METADATA.pb should not contain 'Reserved Font Name'.
  • ⚠️ WARN

    METADATA.pb: copyright field ("Copyright 2020 The Josefin Slab Project Authors (https://github.com/googlefonts/josefinslab/), with Reserved Font Name Josefin.") contains "Reserved Font Name". This is an error except in a few specific rare cases.


    [code: rfn]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+2074 SUPERSCRIPT FOUR: try adding math

Or you can add the above codepoints to one of the subsets supported by the font: latin, menu

[code: unreachable-subsetting]
⚠️ WARN DESCRIPTION.en_us.html should end in a linebreak.
  • ⚠️ WARN

    The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it.


    [code: missing-eof-linebreak]
⚠️ WARN On a family update, the DESCRIPTION.en_us.html file should ideally also be updated.
  • ⚠️ WARN

    The DESCRIPTION.en_us.html file in this family has not changed in comparison to the latest font release on the google/fonts github repo.
    Please consider mentioning note-worthy improvements made to the family recently.


    [code: description-not-updated]
⚠️ WARN Check copyright namerecords match license file.
⚠️ WARN License URL matches License text on name table?
  • ⚠️ WARN

    Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13]


    [code: http-in-description]

  • ⚠️ WARN

    Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13]


    [code: http-in-description]

  • ⚠️ WARN

    Please consider using HTTPS URLs at name table entry [plat=3, enc=1, name=13]


    [code: http-in-description]

⚠️ WARN Check OFL body text is correct.

Lines changed:

+ Copyright (c) 2010, Santiago Orozco ([email protected]), with Reserved Font Name Josefin.\n

[code: incorrect-ofl-body-text]
⚠️ WARN A static fonts directory, if present, must contain manually hinted fonts
  • ⚠️ WARN

    There is a "static" dir but it contains fonts which are not manually hinted. Delete the directory.


    [code: not-manually-hinted]
⚠️ WARN Are there any misaligned on-curve points?
  • ⚠️ WARN

    The following glyphs have on-curve points which have potentially incorrect y coordinates:

* J (U+004A): X=152.5,Y=2.0 (should be at baseline 0?)

* N (U+004E): X=716.0,Y=2.0 (should be at baseline 0?)

* S (U+0053): X=373.0,Y=702.0 (should be at cap-height 700?)

* a (U+0061): X=340.5,Y=374.0 (should be at x-height 375?)

* e (U+0065): X=339.5,Y=373.0 (should be at x-height 375?)

* g (U+0067): X=344.5,Y=374.0 (should be at x-height 375?)

* r (U+0072): X=289.5,Y=373.5 (should be at x-height 375?)

* s (U+0073): X=87.5,Y=0.5 (should be at baseline 0?)

* s (U+0073): X=202.5,Y=2.0 (should be at baseline 0?)

* s (U+0073): X=243.0,Y=376.0 (should be at x-height 375?)

* 17 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-misalignments]
⚠️ WARN Check the direction of the outermost contour in each glyph
  • ⚠️ WARN

    The following glyphs have a counter-clockwise outer contour:

* A (U+0041) has a counter-clockwise outer contour

* AE (U+00C6) has a counter-clockwise outer contour

* Aacute (U+00C1) has a counter-clockwise outer contour

* Aacute (U+00C1) has a counter-clockwise outer contour

* Acircumflex (U+00C2) has a counter-clockwise outer contour

* Acircumflex (U+00C2) has a counter-clockwise outer contour

* Adieresis (U+00C4) has a counter-clockwise outer contour

* Adieresis (U+00C4) has a counter-clockwise outer contour

* Adieresis (U+00C4) has a counter-clockwise outer contour

* Agrave (U+00C0) has a counter-clockwise outer contour

* 292 more.

Use -F or --full-lists to disable shortening of long lists.

[code: ccw-outer-contour]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
⚠️ WARN Checking OS/2 achVendID.
  • ⚠️ WARN

    OS/2 VendorID value ' GOO' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx


    [code: unknown]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/josefinslab


    [code: family-path]
ℹ️ INFO Familyname must be unique according to namecheck.fontdata.com
  • ℹ️ INFO

    The family name "JosefinSlab" seems to be already in use.
    Please visit http://namecheck.fontdata.com for more info.


    [code: name-collision]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/josefinslab/JosefinSlab-Italic[wght].ttf
Dehinted Size 46.9kb
Hinted Size 46.9kb
Increase -24 bytes
Change -0.0 %
[code: size-impact]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- GPOS

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
  • ℹ️ INFO

    This font doesn't have an ARTICLE.en_us.html file.


    [code: missing-article]
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.100']


    [code: version-not-detected]
[2] Family checks
🔥 FAIL Ensure VFs have 'ital' STAT axis.
  • 🔥 FAIL

    Font JosefinSlab[wght].ttf is missing an 'ital' axis.


    [code: missing-ital-axis]

  • 🔥 FAIL

    Font JosefinSlab-Italic[wght].ttf is missing an 'ital' axis.


    [code: missing-ital-axis]

ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 2)

[code: summary]

[31] JosefinSlab[wght].ttf
🔥 FAIL STAT table has Axis Value tables?
  • 🔥 FAIL

    STAT table has no Axis Value tables.


    [code: no-axis-value-tables]
🔥 FAIL Font contains '.notdef' as its first glyph?
  • 🔥 FAIL

    The '.notdef' glyph should contain a drawing, but it is blank.


    [code: notdef-is-blank]
🔥 FAIL Ensure smart dropout control is enabled in "prep" table instructions.
  • 🔥 FAIL

    The 'prep' table does not contain TrueType instructions enabling smart dropout control. To fix, export the font with autohinting enabled, or run ttfautohint on the font, or run the gftools fix-nonhinting script.


    [code: lacks-smart-dropout]
🔥 FAIL Ensure component transforms do not perform scaling or rotation.
  • 🔥 FAIL

    The following glyphs had components with scaling or rotation
    or inverted outline direction:

  • exclamdown (component exclam)
  • guillemotright (component guillemotleft)
  • guilsinglright (component guilsinglleft)
[code: transformed-components]
🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.

But: font copyright string has 'https://github.com/googlefonts/josefinslab', font copyright string has 'https://github.com/googlefonts/josefinslab' and OFL text has 'https://github.com/googlefonts/josefinslab'

[code: mismatch]
🔥 FAIL Shapes languages in all GF glyphsets.
  • 🔥 FAIL

    No GF glyphset was found to be supported >80%, so language shaping support couldn't get checked.


    [code: no-glyphset-supported]
🔥 FAIL Does DESCRIPTION file contain a upstream Git repo URL?
  • 🔥 FAIL

    Please host your font project on a public Git repo (such as GitHub or GitLab) and place a link in the DESCRIPTION.en_us.html file.


    [code: lacks-git-url]
🔥 FAIL Name table strings must not contain the string 'Reserved Font Name'.

This is an error except in a few specific rare cases.

[code: rfn]
🔥 FAIL Check variable font instances
  • 🔥 FAIL

    fvar instances are incorrect:

  • Add missing instances
Name current expected
Thin wght=100.0 wght=100.0
ExtraLight N/A wght=200.0
Light wght=300.0 wght=300.0
Regular wght=400.0 wght=400.0
Medium N/A wght=500.0
SemiBold wght=600.0 wght=600.0
Bold wght=700.0 wght=700.0
[code: bad-fvar-instances]
🔥 FAIL Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • 🔥 FAIL

    Font is missing the 'gasp' table. Try exporting the font with autohinting enabled.
    If you are dealing with an unhinted font, it can be fixed by running the fonts through the command 'gftools fix-nonhinting'
    GFTools is available at https://pypi.org/project/gftools/


    [code: lacks-gasp]
🔥 FAIL Check Google Fonts glyph coverage.
  • 🔥 FAIL

    Missing required codepoints:

- 0x0100 (LATIN CAPITAL LETTER A WITH MACRON)


- 0x0101 (LATIN SMALL LETTER A WITH MACRON)


- 0x0102 (LATIN CAPITAL LETTER A WITH BREVE)


- 0x0103 (LATIN SMALL LETTER A WITH BREVE)


- 0x0104 (LATIN CAPITAL LETTER A WITH OGONEK)


- 0x0105 (LATIN SMALL LETTER A WITH OGONEK)


- 0x0106 (LATIN CAPITAL LETTER C WITH ACUTE)


- 0x0107 (LATIN SMALL LETTER C WITH ACUTE)


- 0x010A (LATIN CAPITAL LETTER C WITH DOT ABOVE)


- 0x010B (LATIN SMALL LETTER C WITH DOT ABOVE)


- 110 more.

Use -F or --full-lists to disable shortening of long lists.

[code: missing-codepoints]
🔥 FAIL Validate STAT particle names and values match the fallback names in GFAxisRegistry.
  • 🔥 FAIL

    STAT table is missing Axis Value Records


    [code: missing-axis-values]
⚠️ WARN Detect any interpolation issues in the font.
  • ⚠️ WARN

    Interpolation issues were found in the font:

- Contour 0 start point differs in glyph 'at' between location wght=100 and location wght=700

- Contour 0 in glyph 'at': becomes underweight between wght=100 and wght=700.

- Contour 0 start point differs in glyph 'section' between location wght=100 and location wght=700

- Contour 0 in glyph 'section': becomes underweight between wght=100 and wght=700.

- Contour 0 start point differs in glyph 'eight' between location wght=100 and location wght=700

- Contour 0 in glyph 'eight': becomes underweight between wght=100 and wght=700.

- Contour 0 start point differs in glyph 'percent' between location wght=100 and location wght=700

- Contour 2 start point differs in glyph 'percent' between location wght=100 and location wght=700

[code: interpolation-issues]

⚠️ WARN Check math signs have the same width.
  • ⚠️ WARN

    The most common width is 524 among a set of 2 math glyphs.
    The following math glyphs have a different width, though:

Width = 543: plus

Width = 680: less

Width = 708: equal

Width = 650: greater

Width = 559: logicalnot

Width = 500: multiply

Width = 501: divide

[code: width-outliers]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Family metadata at ofl/josefinslab does not have an article.


    [code: lacks-article]
⚠️ WARN Copyright notice on METADATA.pb should not contain 'Reserved Font Name'.
  • ⚠️ WARN

    METADATA.pb: copyright field ("Copyright 2020 The Josefin Slab Project Authors (https://github.com/googlefonts/josefinslab/), with Reserved Font Name Josefin.") contains "Reserved Font Name". This is an error except in a few specific rare cases.


    [code: rfn]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+2074 SUPERSCRIPT FOUR: try adding math

Or you can add the above codepoints to one of the subsets supported by the font: latin, menu

[code: unreachable-subsetting]
⚠️ WARN DESCRIPTION.en_us.html should end in a linebreak.
  • ⚠️ WARN

    The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it.


    [code: missing-eof-linebreak]
⚠️ WARN Check OFL body text is correct.

Lines changed:

+ Copyright (c) 2010, Santiago Orozco ([email protected]), with Reserved Font Name Josefin.\n

[code: incorrect-ofl-body-text]
⚠️ WARN A static fonts directory, if present, must contain manually hinted fonts
  • ⚠️ WARN

    There is a "static" dir but it contains fonts which are not manually hinted. Delete the directory.


    [code: not-manually-hinted]
⚠️ WARN Are there any misaligned on-curve points?
  • ⚠️ WARN

    The following glyphs have on-curve points which have potentially incorrect y coordinates:

* Atilde (U+00C3): X=474.0,Y=752.0 (should be at ascender 750?)

* J (U+004A): X=193.0,Y=2.0 (should be at baseline 0?)

* N (U+004E): X=712.0,Y=2.0 (should be at baseline 0?)

* Ntilde (U+00D1): X=712.0,Y=2.0 (should be at baseline 0?)

* Ntilde (U+00D1): X=472.0,Y=752.0 (should be at ascender 750?)

* Otilde (U+00D5): X=459.0,Y=752.0 (should be at ascender 750?)

* OE (U+0152): X=845.0,Y=701.0 (should be at cap-height 700?)

* S (U+0053): X=297.5,Y=702.0 (should be at cap-height 700?)

* b (U+0062): X=243.5,Y=374.0 (should be at x-height 375?)

* d (U+0064): X=288.5,Y=374.0 (should be at x-height 375?)

* 17 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-misalignments]
⚠️ WARN Check the direction of the outermost contour in each glyph
  • ⚠️ WARN

    The following glyphs have a counter-clockwise outer contour:

* A (U+0041) has a counter-clockwise outer contour

* AE (U+00C6) has a counter-clockwise outer contour

* Aacute (U+00C1) has a counter-clockwise outer contour

* Aacute (U+00C1) has a counter-clockwise outer contour

* Acircumflex (U+00C2) has a counter-clockwise outer contour

* Acircumflex (U+00C2) has a counter-clockwise outer contour

* Adieresis (U+00C4) has a counter-clockwise outer contour

* Adieresis (U+00C4) has a counter-clockwise outer contour

* Adieresis (U+00C4) has a counter-clockwise outer contour

* Agrave (U+00C0) has a counter-clockwise outer contour

* 288 more.

Use -F or --full-lists to disable shortening of long lists.

[code: ccw-outer-contour]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/josefinslab


    [code: family-path]
ℹ️ INFO Familyname must be unique according to namecheck.fontdata.com
  • ℹ️ INFO

    The family name "JosefinSlab" seems to be already in use.
    Please visit http://namecheck.fontdata.com for more info.


    [code: name-collision]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/josefinslab/JosefinSlab[wght].ttf
Dehinted Size 44.5kb
Hinted Size 44.5kb
Increase -24 bytes
Change -0.1 %
[code: size-impact]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- GPOS

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
  • ℹ️ INFO

    This font doesn't have an ARTICLE.en_us.html file.


    [code: missing-article]
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.100']


    [code: version-not-detected]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 25 29 97 17 320 0
0% 0% 5% 6% 20% 3% 66% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@kenmcd
Copy link

kenmcd commented Sep 27, 2024

These v2.100 variable fonts do not work in LibreOffice (or Word).
The v2.000 variable fonts from GF work fine.

These v2.100 variable fonts only appear as one font - and only at the Thin weight.
First time I tried I only got the Italic Thin.
So I re-installed v2.000 from GF and it works as expected.
Re-installed v2.100 VF fonts and this time only see the Roman Thin.
No other instances are available.
And Bold and Italic buttons yield fakes.

Windows Font Viewer clicks thru the five styles but only displays the Thin.
With the v2.000 VF fonts all the instances display properly.

The MainType font manager only displays the Thin instance for both the Roman and Italic v2.100 VF fonts.
With v2.000 VF fonts all five instances are listed for both the Roman and Italics fonts.

So my guess is something changed in the STAT table.

Note: I saw the same issue recently with another updated VF family - did not really think about it - and simply installed the static fonts instead. But this has happened a few times now that I think about it. Because lately I have been installing the VFs when families are updated, and when the VFs do not appear correctly I just install the statics.
Seems to be a wider problem.

@vv-monsalve
Copy link
Collaborator

vv-monsalve commented Sep 27, 2024

@emmamarichal Kerning is looking better but the following would be regressions:

🔥 FAIL Check name ID 25 to end with "Italic" for Italic VFs.

The previous font had it.


🔥 FAIL STAT table has Axis Value tables?

The previos version indeed had a STAT table, and the new one lacks it.

old

Screenshot 2024-09-27 at 18 26 34

new

Screenshot 2024-09-27 at 18 26 38

🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.
🔥 FAIL
Repository URL is https://github.com/TypeNetwork/Josefinslab

But: font copyright string has 'https://github.com/googlefonts/josefinslab', font copyright string has 'https://github.com/googlefonts/josefinslab' and OFL text has 'https://github.com/googlefonts/josefinslab'

Either one or the other should be selected.

@vv-monsalve vv-monsalve added the -- Needs Upstream Resolution Upstream fix required before moving forward label Sep 27, 2024
@emmamarichal
Copy link
Collaborator Author

Updated

@emmamarichal emmamarichal force-pushed the gftools_packager_ofl_josefinslab branch from e5eb76d to c5add68 Compare October 11, 2024 13:36
Copy link

FontBakery report

fontbakery version: 0.13.0a1

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[1] JosefinSlab[wght].ttf
⚠️ WARN Checking that the typoAscender exceeds the yMax of the /Agrave.
  • ⚠️ WARN

    OS/2.sTypoAscender value should be greater than 883, but got 750 instead


    [code: typoAscender]
[1] JosefinSlab-Italic[wght].ttf
⚠️ WARN Checking that the typoAscender exceeds the yMax of the /Agrave.
  • ⚠️ WARN

    OS/2.sTypoAscender value should be greater than 883, but got 750 instead


    [code: typoAscender]

All other checks

[26] JosefinSlab[wght].ttf
🔥 FAIL Font contains '.notdef' as its first glyph?
  • 🔥 FAIL

    The '.notdef' glyph should contain a drawing, but it is blank.


    [code: notdef-is-blank]
🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.

But: font copyright string has 'https://github.com/googlefonts/josefinslab', font copyright string has 'https://github.com/googlefonts/josefinslab' and OFL text has 'https://github.com/googlefonts/josefinslab'

[code: mismatch]
🔥 FAIL Shapes languages in all GF glyphsets.
  • 🔥 FAIL

    No GF glyphset was found to be supported >80%, so language shaping support couldn't get checked.


    [code: no-glyphset-supported]
🔥 FAIL Does DESCRIPTION file contain a upstream Git repo URL?
  • 🔥 FAIL

    Please host your font project on a public Git repo (such as GitHub or GitLab) and place a link in the DESCRIPTION.en_us.html file.


    [code: lacks-git-url]
🔥 FAIL Name table strings must not contain the string 'Reserved Font Name'.

This is an error except in a few specific rare cases.

[code: rfn]
🔥 FAIL Check Google Fonts glyph coverage.
  • 🔥 FAIL

    Missing required codepoints:

- 0x0100 (LATIN CAPITAL LETTER A WITH MACRON)


- 0x0101 (LATIN SMALL LETTER A WITH MACRON)


- 0x0102 (LATIN CAPITAL LETTER A WITH BREVE)


- 0x0103 (LATIN SMALL LETTER A WITH BREVE)


- 0x0104 (LATIN CAPITAL LETTER A WITH OGONEK)


- 0x0105 (LATIN SMALL LETTER A WITH OGONEK)


- 0x0106 (LATIN CAPITAL LETTER C WITH ACUTE)


- 0x0107 (LATIN SMALL LETTER C WITH ACUTE)


- 0x010A (LATIN CAPITAL LETTER C WITH DOT ABOVE)


- 0x010B (LATIN SMALL LETTER C WITH DOT ABOVE)


- 110 more.

Use -F or --full-lists to disable shortening of long lists.

[code: missing-codepoints]
⚠️ WARN Detect any interpolation issues in the font.
  • ⚠️ WARN

    Interpolation issues were found in the font:

- Contour 0 start point differs in glyph 'section' between location wght=100 and location wght=700

- Contour 0 in glyph 'section': becomes underweight between wght=100 and wght=700.

- Contour 0 start point differs in glyph 'percent' between location wght=100 and location wght=700

- Contour 2 start point differs in glyph 'percent' between location wght=100 and location wght=700

- Contour 0 start point differs in glyph 'eight' between location wght=100 and location wght=700

- Contour 0 in glyph 'eight': becomes underweight between wght=100 and wght=700.

- Contour 0 start point differs in glyph 'at' between location wght=100 and location wght=700

- Contour 0 in glyph 'at': becomes underweight between wght=100 and wght=700.

[code: interpolation-issues]

⚠️ WARN Check math signs have the same width.
  • ⚠️ WARN

    The most common width is 524 among a set of 2 math glyphs.
    The following math glyphs have a different width, though:

Width = 543: plus

Width = 680: less

Width = 708: equal

Width = 650: greater

Width = 559: logicalnot

Width = 500: multiply

Width = 501: divide

[code: width-outliers]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Family metadata at ofl/josefinslab does not have an article.


    [code: lacks-article]
⚠️ WARN Copyright notice on METADATA.pb should not contain 'Reserved Font Name'.
  • ⚠️ WARN

    METADATA.pb: copyright field ("Copyright 2020 The Josefin Slab Project Authors (https://github.com/googlefonts/josefinslab/), with Reserved Font Name Josefin.") contains "Reserved Font Name". This is an error except in a few specific rare cases.


    [code: rfn]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+2074 SUPERSCRIPT FOUR: try adding math

Or you can add the above codepoints to one of the subsets supported by the font: latin, menu

[code: unreachable-subsetting]
⚠️ WARN DESCRIPTION.en_us.html should end in a linebreak.
  • ⚠️ WARN

    The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it.


    [code: missing-eof-linebreak]
⚠️ WARN Check OFL body text is correct.

Lines changed:

+ Copyright (c) 2010, Santiago Orozco ([email protected]), with Reserved Font Name Josefin.\n

[code: incorrect-ofl-body-text]
⚠️ WARN A static fonts directory, if present, must contain manually hinted fonts
  • ⚠️ WARN

    There is a "static" dir but it contains fonts which are not manually hinted. Delete the directory.


    [code: not-manually-hinted]
⚠️ WARN Are there any misaligned on-curve points?
  • ⚠️ WARN

    The following glyphs have on-curve points which have potentially incorrect y coordinates:

* Atilde (U+00C3): X=474.0,Y=752.0 (should be at ascender 750?)

* J (U+004A): X=193.0,Y=2.0 (should be at baseline 0?)

* N (U+004E): X=712.0,Y=2.0 (should be at baseline 0?)

* Ntilde (U+00D1): X=712.0,Y=2.0 (should be at baseline 0?)

* Ntilde (U+00D1): X=472.0,Y=752.0 (should be at ascender 750?)

* Otilde (U+00D5): X=459.0,Y=752.0 (should be at ascender 750?)

* OE (U+0152): X=845.0,Y=701.0 (should be at cap-height 700?)

* S (U+0053): X=297.5,Y=702.0 (should be at cap-height 700?)

* b (U+0062): X=243.5,Y=374.0 (should be at x-height 375?)

* d (U+0064): X=288.5,Y=374.0 (should be at x-height 375?)

* 17 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-misalignments]
⚠️ WARN Check the direction of the outermost contour in each glyph
  • ⚠️ WARN

    The following glyphs have a counter-clockwise outer contour:

* A (U+0041) has a counter-clockwise outer contour

* AE (U+00C6) has a counter-clockwise outer contour

* Aacute (U+00C1) has a counter-clockwise outer contour

* Aacute (U+00C1) has a counter-clockwise outer contour

* Acircumflex (U+00C2) has a counter-clockwise outer contour

* Acircumflex (U+00C2) has a counter-clockwise outer contour

* Adieresis (U+00C4) has a counter-clockwise outer contour

* Adieresis (U+00C4) has a counter-clockwise outer contour

* Adieresis (U+00C4) has a counter-clockwise outer contour

* Agrave (U+00C0) has a counter-clockwise outer contour

* 293 more.

Use -F or --full-lists to disable shortening of long lists.

[code: ccw-outer-contour]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/josefinslab


    [code: family-path]
ℹ️ INFO Familyname must be unique according to namecheck.fontdata.com
  • ℹ️ INFO

    The family name "JosefinSlab" seems to be already in use.
    Please visit http://namecheck.fontdata.com for more info.


    [code: name-collision]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/josefinslab/JosefinSlab[wght].ttf
Dehinted Size 45.3kb
Hinted Size 45.3kb
Increase 24 bytes
Change 0.1 %
[code: size-impact]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- gasp

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
  • ℹ️ INFO

    This font doesn't have an ARTICLE.en_us.html file.


    [code: missing-article]
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.100']


    [code: version-not-detected]
[28] JosefinSlab-Italic[wght].ttf
🔥 FAIL Font contains '.notdef' as its first glyph?
  • 🔥 FAIL

    The '.notdef' glyph should contain a drawing, but it is blank.


    [code: notdef-is-blank]
🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.

But: font copyright string has 'https://github.com/googlefonts/josefinslab', font copyright string has 'https://github.com/googlefonts/josefinslab' and OFL text has 'https://github.com/googlefonts/josefinslab'

[code: mismatch]
🔥 FAIL Shapes languages in all GF glyphsets.
  • 🔥 FAIL

    No GF glyphset was found to be supported >80%, so language shaping support couldn't get checked.


    [code: no-glyphset-supported]
🔥 FAIL Does DESCRIPTION file contain a upstream Git repo URL?
  • 🔥 FAIL

    Please host your font project on a public Git repo (such as GitHub or GitLab) and place a link in the DESCRIPTION.en_us.html file.


    [code: lacks-git-url]
🔥 FAIL Name table strings must not contain the string 'Reserved Font Name'.

This is an error except in a few specific rare cases.

[code: rfn]
🔥 FAIL Check Google Fonts glyph coverage.
  • 🔥 FAIL

    Missing required codepoints:

- 0x0100 (LATIN CAPITAL LETTER A WITH MACRON)


- 0x0101 (LATIN SMALL LETTER A WITH MACRON)


- 0x0102 (LATIN CAPITAL LETTER A WITH BREVE)


- 0x0103 (LATIN SMALL LETTER A WITH BREVE)


- 0x0104 (LATIN CAPITAL LETTER A WITH OGONEK)


- 0x0105 (LATIN SMALL LETTER A WITH OGONEK)


- 0x0106 (LATIN CAPITAL LETTER C WITH ACUTE)


- 0x0107 (LATIN SMALL LETTER C WITH ACUTE)


- 0x010A (LATIN CAPITAL LETTER C WITH DOT ABOVE)


- 0x010B (LATIN SMALL LETTER C WITH DOT ABOVE)


- 110 more.

Use -F or --full-lists to disable shortening of long lists.

[code: missing-codepoints]
⚠️ WARN Detect any interpolation issues in the font.
  • ⚠️ WARN

    Interpolation issues were found in the font:

- Contour 0 start point differs in glyph 'section' between location wght=100 and location wght=700

- Contour 0 in glyph 'section': becomes underweight between wght=100 and wght=700.

[code: interpolation-issues]

⚠️ WARN Check math signs have the same width.
  • ⚠️ WARN

    The most common width is 543 among a set of 1 math glyphs.
    The following math glyphs have a different width, though:

Width = 680: less

Width = 708: equal

Width = 650: greater

Width = 559: logicalnot

Width = 524: plusminus

Width = 500: multiply

Width = 501: divide

Width = 523: minus

[code: width-outliers]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Family metadata at ofl/josefinslab does not have an article.


    [code: lacks-article]
⚠️ WARN Copyright notice on METADATA.pb should not contain 'Reserved Font Name'.
  • ⚠️ WARN

    METADATA.pb: copyright field ("Copyright 2020 The Josefin Slab Project Authors (https://github.com/googlefonts/josefinslab/), with Reserved Font Name Josefin.") contains "Reserved Font Name". This is an error except in a few specific rare cases.


    [code: rfn]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+2074 SUPERSCRIPT FOUR: try adding math

Or you can add the above codepoints to one of the subsets supported by the font: latin, menu

[code: unreachable-subsetting]
⚠️ WARN DESCRIPTION.en_us.html should end in a linebreak.
  • ⚠️ WARN

    The last characther on DESCRIPTION.en_us.html is not a line-break. Please add it.


    [code: missing-eof-linebreak]
⚠️ WARN On a family update, the DESCRIPTION.en_us.html file should ideally also be updated.
  • ⚠️ WARN

    The DESCRIPTION.en_us.html file in this family has not changed in comparison to the latest font release on the google/fonts github repo.
    Please consider mentioning note-worthy improvements made to the family recently.


    [code: description-not-updated]
⚠️ WARN Check OFL body text is correct.

Lines changed:

+ Copyright (c) 2010, Santiago Orozco ([email protected]), with Reserved Font Name Josefin.\n

[code: incorrect-ofl-body-text]
⚠️ WARN A static fonts directory, if present, must contain manually hinted fonts
  • ⚠️ WARN

    There is a "static" dir but it contains fonts which are not manually hinted. Delete the directory.


    [code: not-manually-hinted]
⚠️ WARN Are there any misaligned on-curve points?
  • ⚠️ WARN

    The following glyphs have on-curve points which have potentially incorrect y coordinates:

* J (U+004A): X=152.5,Y=2.0 (should be at baseline 0?)

* N (U+004E): X=716.0,Y=2.0 (should be at baseline 0?)

* S (U+0053): X=373.0,Y=702.0 (should be at cap-height 700?)

* a (U+0061): X=340.5,Y=374.0 (should be at x-height 375?)

* e (U+0065): X=339.5,Y=373.0 (should be at x-height 375?)

* g (U+0067): X=344.5,Y=374.0 (should be at x-height 375?)

* r (U+0072): X=289.5,Y=373.5 (should be at x-height 375?)

* s (U+0073): X=87.5,Y=0.5 (should be at baseline 0?)

* s (U+0073): X=202.5,Y=2.0 (should be at baseline 0?)

* s (U+0073): X=243.0,Y=376.0 (should be at x-height 375?)

* 17 more.

Use -F or --full-lists to disable shortening of long lists.

[code: found-misalignments]
⚠️ WARN Check the direction of the outermost contour in each glyph
  • ⚠️ WARN

    The following glyphs have a counter-clockwise outer contour:

* A (U+0041) has a counter-clockwise outer contour

* AE (U+00C6) has a counter-clockwise outer contour

* Aacute (U+00C1) has a counter-clockwise outer contour

* Aacute (U+00C1) has a counter-clockwise outer contour

* Acircumflex (U+00C2) has a counter-clockwise outer contour

* Acircumflex (U+00C2) has a counter-clockwise outer contour

* Adieresis (U+00C4) has a counter-clockwise outer contour

* Adieresis (U+00C4) has a counter-clockwise outer contour

* Adieresis (U+00C4) has a counter-clockwise outer contour

* Agrave (U+00C0) has a counter-clockwise outer contour

* 292 more.

Use -F or --full-lists to disable shortening of long lists.

[code: ccw-outer-contour]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
⚠️ WARN Checking OS/2 achVendID.
  • ⚠️ WARN

    OS/2 VendorID value ' GOO' is not yet recognized. If you registered it recently, then it's safe to ignore this warning message. Otherwise, you should set it to your own unique 4 character code, and register it with Microsoft at https://www.microsoft.com/typography/links/vendorlist.aspx


    [code: unknown]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/josefinslab


    [code: family-path]
ℹ️ INFO Familyname must be unique according to namecheck.fontdata.com
  • ℹ️ INFO

    The family name "JosefinSlab" seems to be already in use.
    Please visit http://namecheck.fontdata.com for more info.


    [code: name-collision]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/josefinslab/JosefinSlab-Italic[wght].ttf
Dehinted Size 47.8kb
Hinted Size 47.8kb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- GPOS

- gasp

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO Check for presence of an ARTICLE.en_us.html file
  • ℹ️ INFO

    This font doesn't have an ARTICLE.en_us.html file.


    [code: missing-article]
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.100']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght-ital', 2)

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 12 26 93 19 338 0
0% 0% 2% 5% 19% 4% 69% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@emmamarichal emmamarichal removed the -- Needs Upstream Resolution Upstream fix required before moving forward label Oct 11, 2024
@m4rc1e m4rc1e added P3 and removed P3 labels Oct 14, 2024
@emmamarichal
Copy link
Collaborator Author

sorry @vv-monsalve, forgot to tag you on the update! it's ready to review!

@m4rc1e
Copy link
Collaborator

m4rc1e commented Nov 1, 2024

Previous font didn't kerning or the kerns have drastically changed

jose_kern

If we're happy with the new kerning then its LGTM. STAT is now back.

@emmamarichal
Copy link
Collaborator Author

@m4rc1e Yeah the kerning was the issue I was solving at the beggining! It's not perfect, but "less worst" let say hehe :)

@vv-monsalve
Copy link
Collaborator

@emmamarichal, as we discussed, I'm reporting the spotted pairs.

Screenshot 2024-11-01 at 10 41 11

@vv-monsalve vv-monsalve added the -- Needs confirmation from upstream or onboarder label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: PR GF
Development

Successfully merging this pull request may close these issues.

Improve Josefin Slab kerning
4 participants