Agu Display: Version 1.099 added #8487
Open
+149
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
|
Updated |
n8willis
force-pushed
the
gftools_packager_ofl_agudisplay
branch
from
81fe77a
to
e165274
Compare
This comment was marked as outdated.
This comment was marked as outdated.
9 tasks
n8willis
added
II Commissioned
Taken from the upstream repo https://github.com/theseunbadejo/Agu-Display at commit theseunbadejo/Agu-Display@91111b8.
m4rc1e
force-pushed
the
gftools_packager_ofl_agudisplay
branch
from
e165274
to
d51351c
Compare
FontBakery reportfontbakery version: 0.13.0a5 Check results[19] AguDisplay[MORF].ttf💥 ERROR Familyname must be unique according to namecheck.fontdata.com
[code: namecheck-service] 🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.
But: font copyright string has 'https://github.com/theseunbadejo/nsibidi-libre/blob/main/AUTHORS.txt' and OFL text has 'https://github.com/googlefonts/googlefonts-project-template' [code: mismatch]🔥 FAIL Shapes languages in all GF glyphsets.
|
| ofl/agudisplay/AguDisplay[MORF].ttf | |
|---|---|
| Dehinted Size | 757.7kb |
| Hinted Size | 757.7kb |
| Increase | 24 bytes |
| Change | 0.0 % |
ℹ️ INFO Font contains all required tables?
- ℹ️ INFO
This font contains the following optional tables:
- loca
- prep
- GPOS
- GSUB
- gasp
[code: optional-tables]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
- ℹ️ INFO
These are the ppm ranges declared on the gasp table:
PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®
[code: ranges][1] Family checks
Summary
| 💥 ERROR | ☠ FATAL | 🔥 FAIL | ⏩ SKIP | ℹ️ INFO | ✅ PASS | 🔎 DEBUG | |
|---|---|---|---|---|---|---|---|
| 1 | 0 | 2 | 10 | 56 | 7 | 176 | 0 |
| 0% | 0% | 1% | 4% | 22% | 3% | 70% | 0% |
Note: The following loglevels were omitted in this report:
- SKIP
- PASS
- DEBUG
|
@n8willis I've restored the first PR comment information including the checklist, it is key to our process, please do not delete it.
|
|
Looking at the built binaries, the VF version appears to have "Uzo" as the subfamily name.
I thought that had been sorted out previously. I may have thinking about the static instances. TTX |
|
@m4rc1e Is that just an artifact of Uzo being at MORF=0? |
|
@vv-monsalve Were you intending to tag me on this?
Just for the record, I did not delete it. |
Bad tagging indeed! Thank you for the clarification. Fixed it now. |
As far as I can tell from the timestamps, the comment was "edited" at the same moment the first update push landed & the page refreshed. So maybe the update-as-someone-checks-checkboxes collides in transit with the page refresh. I don't know. It makes one wonder though. |
Uhm! You're probably right. IIRC, Emma reported it before on another PR. @m4rc1e seems the packager is still doing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken from the upstream repo https://github.com/theseunbadejo/Agu-Display at commit theseunbadejo/Agu-Display@91111b8.
minisite_urldefinition in the METADATA.pb file for commissioned projectsprimary_scriptdefinition in the METADATA.pb file for all projects that have a primary non-Latin based language support targetsubsetsdefinitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsetschinese-hongkong,chinese-simplified,chinese-traditional,korean,japanese.