fix: mutate.Extract
path manipulation on Windows
#2015
+57
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mutate.Extract
replaces/
with\
on Windows (even for non-Windows images) due to the use offilepath.Clean()
, and other functions (e.g.,filepath.Dir
) that ultimately callfilepath.Clean
on the result.This is typically not desired, since:
/
as a path separator, if the result is meant to be extracted on Windows\
Add an
imageFS
interface to abstract away path manipulation operations (e.g.,Dir
,Base
,Clean
,Join
), with the default case beingfilepath.*
, but allows usingpath.*
if extracting a non-Windows image on Windows.Note: extracting a Windows image on Linux is left as is, since neither
path
norfilepath
will be able to appropriately handle the paths if the separator is\
.