Expose image 'DeleteTag' method in the 'daemon' #2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method is needed to enable image cleanup in the container-structure-tests. The problem I'm trying to solve is that container-structure-tests are writing an image to docker https://github.com/GoogleContainerTools/container-structure-test/blob/c35e48dcd5dd[…]ec6d50d688235d4a36/cmd/container-structure-test/app/cmd/test.go but they are not deleting it at all. This leads to leaked registry.structure_test.oci.local/image that accumulate in CICD.
sfc-gh-ptabor
force-pushed
the
20241011-removeTag
branch
from
ef75fbc
to
93d189d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method is needed to enable image cleanup in the container-structure-tests.
The problem I'm trying to solve is that container-structure-tests are writing an image to docker
https://github.com/GoogleContainerTools/container-structure-test/blob/c35e48dcd5dd[…]ec6d50d688235d4a36/cmd/container-structure-test/app/cmd/test.go
but they are not deleting it at all. This leads to leaked registry.structure_test.oci.local/image that accumulate in CICD.