[Bug #4953] Enable GTEST_HAS_ABSL by default when using bzlmod#4954
Open
codelovingcat wants to merge 2 commits into
Open
[Bug #4953] Enable GTEST_HAS_ABSL by default when using bzlmod#4954codelovingcat wants to merge 2 commits into
codelovingcat wants to merge 2 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable
GTEST_HAS_ABSLby default when using bzlmod/BCR.Problem
When using bzlmod,
abseil-cppis an unconditional dependency, butGTEST_HAS_ABSLdefaults to off.This causes features like
AbslStringifyto fail, print incorrect values, or cause compilation errors.Solution
config_settingnamedbzlmod_enabledtriggered by--enable_bzlmod=true.//:gtestdefinesanddepsselect()statements to enableGTEST_HAS_ABSL=1and link Abseil if either:--define absl=1(:has_absl):bzlmod_enabled)Backward Compatibility
--define absl=1to enable Abseil support.Testing
bazel test //... --enable_bzlmod=true