Fix: InitGoogleTest now consumes and removes the --help flag#4959
Open
Root-Aamir wants to merge 1 commit into
Open
Fix: InitGoogleTest now consumes and removes the --help flag#4959Root-Aamir wants to merge 1 commit into
Root-Aamir wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
1348897 to
1abf935
Compare
Author
|
I have signed the CLA. |
Author
|
@googlebot I signed it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, when
--helpis passed to a GoogleTest binary,InitGoogleTestsets the internal help flag but does not remove the flag fromargv. This prevents downstream argument parsers from knowing that the flag has already been handled.Changes
ParseGoogleTestFlagsOnlyImplingtest.ccto setremove_flag = truewhen--helpor other unrecognized GTest flags are encountered.argcis decremented and the help flag is removed from the arguments list after initialization.Verification
Reproduced the issue with a manual test runner.
argcremained 2 afterInitGoogleTestwhen passing--help.argccorrectly becomes 1.