Improve ElementsAreArray mismatch explanations for readability #4934#4976
Open
ShrutiPundir17 wants to merge 4 commits into
Open
Improve ElementsAreArray mismatch explanations for readability #4934#4976ShrutiPundir17 wants to merge 4 commits into
ShrutiPundir17 wants to merge 4 commits into
Conversation
Use structured Expected/Actual-oriented diagnostics for ElementsAre and UnorderedElementsAre failures, and update matcher container tests to assert the new clearer output format.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Add a short comment documenting why unordered pairing diagnostics print in Actual/Expected order.
Drop the follow-up comment added for CLA retrigger so the PR includes only necessary matcher output changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4934
Summary
This change improves failure diagnostics for
ElementsAre*andUnorderedElementsAre*matchers by making explanations more structured and easier to scan during debugging loops.What changed
ElementsAreMatcherImplmismatch explanations to be more explicit:element #N matches: ...form.ExpectedvsActualterminology:Expected #...Actual #...Actual #X <-> Expected #YWhy
Current output for
(Unordered)ElementsAreArrayfailures can be difficult to parse quickly, especially with large struct payloads.This change prioritizes:
Scope
Only diagnostic message formatting and corresponding tests were changed.
Matching semantics and matcher algorithms are unchanged.
Files touched
googlemock/include/gmock/gmock-matchers.hgooglemock/src/gmock-matchers.ccgooglemock/test/gmock-matchers-containers_test.cc