[Issue-2816] - Update exception type in JsonDeserializer to JsonSyntaxException #2820
+3
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…xException
Purpose
Closes #2816
Description
As mentioned in #2816 , If
_com.google.gson.Gson.fromJson(String, Class<User>)_throwsJsonSyntaxExceptionbut in case any one imeplements custom JsonDeserializer then it by default throws JsonParseException.For any
com.google.gson.Gson.fromJson(String, Class<User>)calls , its normal to catchJsonSyntaxException, But in case use ofJsonDeserializer, this exception will not be caught.Ideally fromJson and JsonDeserializer interface should throw same exceptions.
Checklist
This is automatically checked by
mvn verify, but can also be checked on its own usingmvn spotless:check.Style violations can be fixed using
mvn spotless:apply; this can be done in a separate commit to verify that it did not cause undesired changes.null@since $next-version$(
$next-version$is a special placeholder which is automatically replaced during release)TestCase)mvn clean verify javadoc:jarpasses without errors