Skip to content

Conversation

@Jaehwa-Noh
Copy link
Contributor

Animation is not necessary during on test and it likely leads unexpected test failure result.
And disable animation rid animation waiting time.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Jaehwa-Noh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the stability and speed of Android instrumented tests by configuring all relevant modules to disable animations during their execution. This change directly addresses potential test flakiness that can arise from animation timings and concurrently reduces the overall test execution duration, contributing to a more reliable and efficient continuous integration pipeline.

Highlights

  • Test Reliability: Animations are now disabled during instrumented tests to prevent unexpected failures and flakiness caused by animation timings.
  • Test Performance: Disabling animations reduces the waiting time associated with UI transitions, leading to faster test execution times.
  • Configuration Update: The animationsDisabled = true flag has been consistently added to the testOptions block across multiple build.gradle.kts files in various modules.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly disables animations for instrumented tests across multiple modules, which is a great improvement for test stability and performance. My main feedback is about the code duplication this introduces. The same animationsDisabled = true setting has been added to eight separate build.gradle.kts files. To improve long-term maintainability, I recommend centralizing this configuration. I've left a specific comment in app/build.gradle.kts with suggestions on how to achieve this, such as using a shared Gradle script or a convention plugin.

Comment on lines 81 to +83
testOptions {
execution = "ANDROIDX_TEST_ORCHESTRATOR"
animationsDisabled = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While disabling animations for tests is a good practice for improving stability and performance, this change introduces the same configuration to 8 different build.gradle.kts files. This duplication can lead to maintenance challenges in the future, such as forgetting to add it to new modules or having to update it in multiple places.

To improve maintainability, I recommend centralizing this configuration. You could, for example, extract this into a common script in the gradle/ directory and apply it where needed. An even better, more scalable approach for a multi-module project like this would be to use convention plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants