-
Notifications
You must be signed in to change notification settings - Fork 49
Disable animation on android instrumented test #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @Jaehwa-Noh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the stability and speed of Android instrumented tests by configuring all relevant modules to disable animations during their execution. This change directly addresses potential test flakiness that can arise from animation timings and concurrently reduces the overall test execution duration, contributing to a more reliable and efficient continuous integration pipeline. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly disables animations for instrumented tests across multiple modules, which is a great improvement for test stability and performance. My main feedback is about the code duplication this introduces. The same animationsDisabled = true setting has been added to eight separate build.gradle.kts files. To improve long-term maintainability, I recommend centralizing this configuration. I've left a specific comment in app/build.gradle.kts with suggestions on how to achieve this, such as using a shared Gradle script or a convention plugin.
| testOptions { | ||
| execution = "ANDROIDX_TEST_ORCHESTRATOR" | ||
| animationsDisabled = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While disabling animations for tests is a good practice for improving stability and performance, this change introduces the same configuration to 8 different build.gradle.kts files. This duplication can lead to maintenance challenges in the future, such as forgetting to add it to new modules or having to update it in multiple places.
To improve maintainability, I recommend centralizing this configuration. You could, for example, extract this into a common script in the gradle/ directory and apply it where needed. An even better, more scalable approach for a multi-module project like this would be to use convention plugins.
Animation is not necessary during on test and it likely leads unexpected test failure result.
And disable animation rid animation waiting time.