Clean up and update Bazel build files #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbartholomew
force-pushed
the
bazelfixes
branch
3 times, most recently
from
3f710a0 to
5b48ef0
Compare
Significant changes here: - The WORKSPACE file is removed. Bazel disables WORKSPACE by default anyway in Bazel 8, and bzlmod has been available to use for several versions before that. - Update rules_python module. Remove the custom Python toolchain infrastructure which is only used to find a Python C header to include, instead use @rules_python//python/cc:current_py_cc_headers. - Make build targets private by default. Explicitly make public just the ones that are actually public interface (the jsonnet and jsonnetfmt command line tools, the C, C++ and Python libraries). - Keep internal headers private.
This is mostly so that I can set it up to be used in the module registry presubmit, but it does also act as an example.
johnbartholomew
force-pushed
the
bazelfixes
branch
from
5b48ef0 to
dc52f56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Significant changes here:
The WORKSPACE file is removed. Bazel disables WORKSPACE by default anyway in Bazel 8, and bzlmod has been available to use for several versions before that.
Update rules_python module. Remove the custom Python toolchain infrastructure which is only used to find a Python C header to include, instead use @rules_python//python/cc:current_py_cc_headers.
Make build targets private by default. Explicitly make public just the ones that are actually public interface (the jsonnet and jsonnetfmt command line tools, the C, C++ and Python libraries).
Don't expose the internal Jsonnet headers publicly. Private headers in a cc_library should not be in
hdrsthey should be listed insrc.Update googletest.