Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: windows compile fix on vs2022 #1214

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Simonhancrew
Copy link

my env settings

windows sdk == 10.0.22000.0
clang == 18.1.0rc

compile errors occurs like below

  • deprecated-declarations
db_bench.cc:1116:16: error: 'sscanf' is deprecated: This function or variable may be unsafe. Consider using sscanf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [-Werror,-Wdeprecated-declarations]

and benchmark also has some waring issue like

benchmark/src/benchmark.cc:206:7: error: offset of on non-standard-layout type 'State' [-Werror,-Winvalid-offsetof]
  206 |       offsetof(State, skipped_) <= (cache_line_size - sizeof(skipped_)), "")

Copy link

google-cla bot commented Nov 10, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant