Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to protobuf 3.25.1 #3394

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support to protobuf 3.25.1 #3394

wants to merge 2 commits into from

Conversation

sergiomb2
Copy link

new-protobuf-cmake-logic.patch

@sergiomb2 sergiomb2 requested a review from a team as a code owner January 20, 2024 22:46
@google-cla Google CLA
Copy link

google-cla bot commented Jan 20, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Vogtinator
Copy link

This breaks building shared libraries here.

It can be fixed and simplified a lot by avoiding the proto-object intermediate library: sergiomb2#1

@sergiomb2
Copy link
Author

I just maintain package libphonenumber on Fedora Linux , I will test it Thank you

@sergiomb2
Copy link
Author

❌ Missing CLA from one or more contributors . @Vogtinator can you sign the CLA ?

@Vogtinator
Copy link

I'll have to ask around a bit. Supposedly we have a corporate CLA signed, so my address would just need to be added to the list.

@Vogtinator
Copy link

I'll have to ask around a bit. Supposedly we have a corporate CLA signed, so my address would just need to be added to the list.

That's done now, but with a different mail address. Can you just amend my commit with s/suse.de/suse.com/?

@sergiomb2
Copy link
Author

sergiomb2 commented Feb 22, 2024 •
edited
Loading

yes, replace your commit do a new pull request to me
please
I will rebase with your commit

@lonnieashley72
Copy link

lonnieashley72 commented Feb 22, 2024 via email

bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Feb 23, 2024
@bmwiedemann
Update libphonenumber to version 8.13.30 / rev 7 via SR 1149426
914922c 
https://build.opensuse.org/request/show/1149426
by user Vogtinator + anag+factory
- Update to version 8.13.30:
  * Update alternate formatting data, phone metadata, geocoding
    data, carrier data
  * Updated / refreshed time zone meta data.
  * New geocoding data
- Add patch submitted to upstream at gh#google/libphonenumber#3394
  to fix building with protobuf 3.25.1:
  * 0001-Add-support-to-protobuf-3.25.1.patch
- Add patch submitted in gh#sergiomb2/libphonenumber#1 by
  Fabian Vogt:
  * 0002-Avoid-intermediate-proto-object-library.patch

- Update to version 8.13.23: (forwarded request 1149395 from alarrosa)
sergiomb2 and others added 2 commits February 25, 2024 01:16
@sergiomb2
Add support to protobuf 3.25.1
ce29cb7 
new-protobuf-cmake-logic.patch
@Vogtinator @sergiomb2
Avoid intermediate proto-object library
8eab7e1 
The use of proto-object breaks building shared libs and it doesn't make
sense to install it. Instead of TARGET, use generate_protobuf with OUT_VAR.
@sergiomb2
Copy link
Author

done ! , please ignore the spammer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sergiomb2 @Vogtinator @lonnieashley72