Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1491

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README.md #1491

wants to merge 1 commit into from

Conversation

ed-software
Copy link

This change adds a reference to the library react-material-symbols, a library that wraps the official font-based API into a React first API.

If there is any reason why this library should not be listed here, I would love to hear feedback.

@google-cla
Copy link

google-cla bot commented Mar 19, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@tphinney tphinney self-requested a review March 19, 2023 21:32
Copy link

@scarabaeus scarabaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfbrennan
Copy link

jfbrennan commented Sep 7, 2023

Material Symbols are for the whole web platform (and OS platforms). React libs fall under the web umbrella along with Vue, Svelte, Riot, Angular, Lit, Preact, Ember, Solid, Ionic, Stencil, Alpine, Aurelia, etc etc etc. None of those are crying for attention on the readme...

This kind of promotion creates tunnel-vision within the developer community and unintentionally creates artificial demand for React. And it creates the illusion of a lack of other options. Let people using React find React solutions. Let's stop giving React special treatment and keep the web neutral.

Copy link

@the1Riddle the1Riddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is nice, but also needs conflict resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants