-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #1491
base: master
Are you sure you want to change the base?
Update README.md #1491
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Material Symbols are for the whole web platform (and OS platforms). React libs fall under the web umbrella along with Vue, Svelte, Riot, Angular, Lit, Preact, Ember, Solid, Ionic, Stencil, Alpine, Aurelia, etc etc etc. None of those are crying for attention on the readme... This kind of promotion creates tunnel-vision within the developer community and unintentionally creates artificial demand for React. And it creates the illusion of a lack of other options. Let people using React find React solutions. Let's stop giving React special treatment and keep the web neutral. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is nice, but also needs conflict resolution.
This change adds a reference to the library react-material-symbols, a library that wraps the official font-based API into a React first API.
If there is any reason why this library should not be listed here, I would love to hear feedback.