Fix hunting ruleset API parameters and type hints #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the documentation at https://gtidocs.virustotal.com/reference/list-hunting-rulesets, the
intelligence/hunting_rulesetsendpoint is designed to retrieve registered rulesets and does not require a rule_id parameter. I have removed the ruleset_id parameter and updated the function to support filter arguments instead.Additionally, I have updated the type hints for get_entities_related_to_a_hunting_ruleset to align with this change.
As a separate issue, I also found a type hint mismatch in get_entities_related_to_a_file and fixed it using the same approach as before.
Before
After
