fix: Correctly handle lines that cross buffer boundaries. #902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results 1 files 27 suites 8m 51s ⏱️ Results for commit b35d739. ♻️ This comment has been updated with latest results. |
We explicitly check for reading across buffer boundaries in test. Issue: #637
Add a `Finish` function to clear out the last bytes at shutdown.
Add a wrapping struct to add a Read method to the dgram connection.
Skip a test whose `want` is now invalid.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileStreamhad been fixed a while back but we still had this problem for the otherLogStreamimplementations.This new code extracts the common read handling and manages the read buffer between calls.
It regresses in the handling of rune errors by choosing to do nothing to them instead of converting them. It is also faster in half the BenchmarkProgram benchmarks as a result of not caring to decode the runes. The other half... are they slower because the decoder has been fixed to not skip bytes?
Issue: #637