-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect Benchmark Status on report's Index Page #721
Comments
@DonggeLiu Hi, I'd like to work on this issue |
Sure, thanks @ay-bh ! |
Can this issue be assigned to multiple person? @DonggeLiu |
Hi @Jett-Code, |
Hey @DonggeLiu, Would like to get your thoughts on this, I feel this should address it: In Creating a helper method Updating the logic in if this looks good to you, I'll raise a PR. |
Thanks! Replied in your PR. |
The status of each benchmark on the index page is currently determined solely by the trials included in the report. This approach leads to misleading statuses when not all trials are accounted for in the report.
Example:
Done
.Done
.Expected Behavior:
The benchmark's status should be
Running
because results for the remaining 9 trials are still pending.The text was updated successfully, but these errors were encountered: