Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Incorrect Benchmark Status on Report's Index Page #846

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jett-Code
Copy link

Description
This PR fixes issue #721 where the benchmark status is incorrectly reported as 'Done' when not all trials are accounted for. Currently, the status is determined solely by the trials included in the report, leading to misleading statuses when some trials are still pending.

Changes
Modified the match_benchmark method in the Results class to properly check if all expected trials are present and completed before marking a benchmark as 'Done'.

Implementation Details
The fix compares the number of trials in the results list with the total expected number of trials for the benchmark (from the targets list). It sets the status to 'Done' only if all expected trials are present and completed.

Copy link

google-cla bot commented Mar 10, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant