Fix Incorrect Benchmark Status on Report's Index Page #846
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #721 where the benchmark status is incorrectly reported as 'Done' when not all trials are accounted for. Currently, the status is determined solely by the trials included in the report, leading to misleading statuses when some trials are still pending.
Changes
Modified the match_benchmark method in the Results class to properly check if all expected trials are present and completed before marking a benchmark as 'Done'.
Implementation Details
The fix compares the number of trials in the results list with the total expected number of trials for the benchmark (from the targets list). It sets the status to 'Done' only if all expected trials are present and completed.