Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename gen code to query llm #480

Merged
merged 3 commits into from
Jul 14, 2024
Merged

Conversation

DavidKorczynski
Copy link
Collaborator

@DavidKorczynski DavidKorczynski commented Jul 14, 2024

The main reason for this is that the generate_code does not really generate any code but rather it queries a given LLM using a specified prompt. Since we now have prompts of various sort, I feel it might be a bit misplaced the name. This could also make it a bit more clear which API to use if you're working on using LLMs for tasks other than explicit code generation.

This came up while doing #479 where one consideration was to have the LLM generate a corpus explicit without going a seed-corpus-by-way-of-python generation.

Ref: #482

Signed-off-by: David Korczynski <[email protected]>
Signed-off-by: David Korczynski <[email protected]>
@DavidKorczynski
Copy link
Collaborator Author

/gcbrun exp -n dk-test-infra-99 -m vertex_ai_gemini-1-5 -b minor-for-ci -i

Signed-off-by: David Korczynski <[email protected]>
@DavidKorczynski
Copy link
Collaborator Author

Experiment is looking good.

@mihaimaruseac mihaimaruseac merged commit a19eb1a into main Jul 14, 2024
7 checks passed
@mihaimaruseac mihaimaruseac deleted the rename-gen-code-to-query-llm branch July 14, 2024 21:51
Copy link
Collaborator

@DonggeLiu DonggeLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants