fix: consider fuzzing successful if semantic check passes #685
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desc
A fuzzing result should be considered successful if the semantic check yields an error type other than SemanticCheckResult.NOT_APPLICABLE or SemanticCheckResult.NO_SEMANTIC_ERR (see fuzz_target_error.py#L163).
Currently, in builder_runner.py#L519, the code incorrectly marks the run as failed when the semantic result has the desired error type, preventing an early stop on successful fuzzing - evaluator.py#L391