Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try setting maxtasksperchild=1 #707

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Try setting maxtasksperchild=1 #707

merged 1 commit into from
Nov 8, 2024

Conversation

oliverchang
Copy link
Collaborator

This makes us create fresh instances for every experiment.

Speculative fix for some issue we're seeing with hanging experiments.

@oliverchang
Try setting maxtasksperchild=1
0197d5f 
This makes us create fresh instances for every experiment. 

Speculative fix for some issue we're seeing with hanging experiments.
@oliverchang oliverchang merged commit 5be0cad into main Nov 8, 2024
5 of 6 checks passed
@oliverchang oliverchang deleted the oliverchang-patch-4 branch November 8, 2024 01:53
DonggeLiu
DonggeLiu reviewed Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@DonggeLiu DonggeLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is this causing memory leak?

@oliverchang
Copy link
Collaborator Author

LGTM, is this causing memory leak?

Not sure, I wasn't able to debug the existing experiment in #692 with gdb prior to #705.

If this happens again, we'll be able to gdb inside the containers to see what's happening with these child processes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonggeLiu DonggeLiu DonggeLiu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverchang @DonggeLiu