Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cjsonobject patch 1 #12713

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

esraercann
Copy link

Integration of cjsonobject library was performed. w/ @fatihhcelik

Copy link

google-cla bot commented Nov 14, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

esraercann is integrating a new project:
- Main repo: https://github.com/Bwar/CJsonObject.git
- Criticality score: 0.46011

@esraercann esraercann changed the title Esraercann patch 1 cjsonobject patch 1 Nov 14, 2024
Copy link
Collaborator

@DavidKorczynski DavidKorczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you elaborate on who the users are of this project, and why it's security critical?

FROM gcr.io/oss-fuzz-base/base-builder
#RUN apt-get update && apt-get install -y cmake docbook2x make
ENV FUZZING_LANGUAGE="c++"
ENV LIB_FUZZING_ENGINE="libfuzzer"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use OSS-Fuzz's environment variables for all of these things. Don't set them hardcoded yourself

# Set up environment for OSS-Fuzz with compiler and linker flags

export CXXFLAGS="-fsanitize=fuzzer"
export CXX="clang++"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the OSS-Fuzz conventions for environment variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants