ui: make datagrid filter chips editable#6029
Draft
gignat-dev wants to merge 2 commits into
Draft
Conversation
Allow users to edit existing data grid filters by clicking on the
filter chip. This opens a popup with the appropriate editor (multiselect
or text input) pre-filled with the current filter value, rather than
forcing users to delete and recreate the filter from scratch.
Implementation details:
- Adds an onEdit callback to GridFilterChip, guarding against clicks
on the remove button.
- Introduces EditFilterMenu which smartly reuses the existing
TextFilterSubmenu and DistinctValuesSubmenu based on the filter type.
- Promotes = to in and != to not in when editing text/identifier
columns to seamlessly match the add-mode multiselect wire shape.
- Pins initially selected items to the top of the multiselect menu so
they remain visible and stable during the edit.
🎨 Perfetto UI Builds
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow users to edit existing data grid filters by clicking on the filter chip. This opens a popup with the appropriate editor (multiselect or text input) pre-filled with the current filter value, rather than forcing users to delete and recreate the filter from scratch.
Implementation details:
=toinand!=tonot inwhen editing text/identifier columns to seamlessly match the add-mode multiselect wire shape.Screenshots (trace: AndroidExample)
infilter chip>=filter chipglobfilter chip