tp: Add TrackEvent plugin registry + android_track_event_process table#6158
Open
zezeozue wants to merge 1 commit into
Open
tp: Add TrackEvent plugin registry + android_track_event_process table#6158zezeozue wants to merge 1 commit into
zezeozue wants to merge 1 commit into
Conversation
TrackEventParser gains a field-id-keyed plugin registry. The frameworks/base plugin feeds the process table from process lifecycle events -- start sets name/uid via GetOrCreateProcess, binder-died EndThread()s the pid -- and keeps the framework start/end timestamps in the new __intrinsic_android_track_event_process table (upid, fw_start_ts, fw_end_ts). Drops the aliased IMPORTANCE_BACKGROUND enumerator, which pbzero's switch-based ToString rejects under -Werror. This field is deprecated in favor of importance_cached anyways. Change-Id: I958d9c9707d0f5629a17eb3468beb82a20fbf923
🎨 Perfetto UI Builds
|
LalitMaganti
reviewed
Jun 5, 2026
| parser_->AddActiveProcess(ts_, *it); | ||
| } | ||
| } | ||
|
|
| stats::track_event_dropped_packets_outside_of_range_of_interest); | ||
| return; | ||
| } | ||
| plugins_->ParseFields(blob, ts); |
Member
There was a problem hiding this comment.
Shouldn't this return something? This feels very very as hoc here. We need to design this a bit better with various sets of callbacks:
- there's a layer here if you want to intercept the whole event and do parsing from scratch
- then there's another layee which lives purely at the args level
My theory is that you only want 2) right now in which case you should do this in trackeventeventimporter
| class TrackEventPlugin { | ||
| public: | ||
| virtual ~TrackEventPlugin(); | ||
| virtual void ParseField(uint32_t field_id, |
Member
There was a problem hiding this comment.
This is too opaque. What is allowed, what is not allowed here? This need comments. I would also scope this down and say this is only about args associated with an event. So you can pass the slice id or counter I'd you've inserted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TrackEventParser gains a field-id-keyed plugin registry.
The frameworks/base plugin feeds the process table from process lifecycle events -- start sets name/uid via GetOrCreateProcess, binder-died EndThread()s the pid -- and keeps the framework start/end timestamps in the new __intrinsic_android_track_event_process table (upid, fw_start_ts, fw_end_ts).
Drops the aliased IMPORTANCE_BACKGROUND enumerator, which pbzero's switch-based ToString rejects under -Werror. This field is deprecated in favor of importance_cached anyways.