Collapse isolated UIDs into one CPU per UID track#6644
Open
rzuklie wants to merge 3 commits into
Open
Conversation
There can be many thousand isolated UIDs in a trace which is not particularly helpful to a user and is expensive for queries. This change treats isolated UIDs and shared UIDs similar to the totals tracks, where the delta is accumulated and written at the end of packet handling. One subtle point: the last_value_ and delta_ms calculation is moved out of ComputeTotals, since we're now passing the canonicalized UID in which would break the delta calculation. I also decided to consolidate the interned and local last_value calculation in one function for clarity.
🎨 Perfetto UI Builds
|
LalitMaganti
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There can be many thousand isolated UIDs in a trace which is not particularly helpful to a user and is expensive for queries. This change treats isolated UIDs and shared UIDs similar to the totals tracks, where the delta is accumulated and written at the end of packet handling.
One subtle point: the last_value_ and delta_ms calculation is moved out of ComputeTotals, since we're now passing the canonicalized UID in which would break the delta calculation. This also puts the incremental and global last_value calculation in one function and tries to explain why they both exist.