Detect the program name when python -m was executed
#424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbieber
reviewed
Dec 20, 2022
| Display(output, out=sys.stdout) | ||
|
|
||
|
|
||
| def _GetProgName(name, main=None): |
There was a problem hiding this comment.
In the current PR I don't think the main arg is passed anywhere (other than the test). Is a file missing?
There was a problem hiding this comment.
It is only passed during testing.
|
Good idea! Thanks for submitting 👍 |
dukecat0
commented
Dec 21, 2022
| Args: | ||
| name: Optional. The name of the command as entered at the command line. | ||
| main: Optional. This should only be passed during testing. |
|
The new behavior doesn't look quite like what we want: Instead, we'd prefer the following, right? |
|
It looks like the quotes come from here: Line 190 in 91febb4 I think the reason is that there are spaces inside self.name, i.e. /usr/bin/python -m sample. Any opinions on how should we deal with this case?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #76
Old behaviour:
New behaviour: