Skip to content

Conversation

@maroux
Copy link
Contributor

@maroux maroux commented May 5, 2020

  • This allows one to name an index the same as a field like so:
class FieldCustomNameTestModel(model.Model):
  __table__ = 'FieldCustomNameTestModel'

  key = field.Field(field.String, primary_key=True)
  value = field.Field(field.String, nullable=False)

  value_idx = index.Index(['value'], name='value')

maroux added 2 commits May 5, 2020 11:43
- This allows one to name an index the same as a field
@dgorelik
Copy link
Contributor

Hi, sorry for a delayed review. We are now trying to make use of the Cloud Spanner Emulator for testing. Can you add some test coverage which uses the Cloud Spanner Emulator? See this example: https://github.com/google/python-spanner-orm/blob/a95d8dc9c779f0aeba6158e1f799582f1924e426/spanner_orm/tests/migrations_emulator_test.py

@dgorelik dgorelik self-requested a review August 12, 2020 20:56
Base automatically changed from master to main January 26, 2021 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants