Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VRT failures in CI #9559

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

Fix VRT failures in CI #9559

wants to merge 14 commits into from

Conversation

tofumatt
Copy link
Collaborator

Summary

Addresses issue:

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@tofumatt tofumatt changed the title Vrt-fixes-9528 Fix VRT failures in CI Oct 24, 2024

RUN apk upgrade --no-cache --available && \
PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true npm i -g backstopjs@${BACKSTOPJS_VERSION} && \
RUN apt-get update
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Run commands must be combined into one.


ARG BACKSTOPJS_VERSION=6.1.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Group ARGs together:

ARG ...
ARG ...

ENV ...


ARG BACKSTOPJS_VERSION=6.1.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is the newer version of backstopjs - 6.3.2. We should probably upgrade it as well, shouldn't we?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, sorry, I missed that 👍🏻

@eugene-manuilov
Copy link
Collaborator

Also, there are two ca-certificates packages are being installed. We need to cleanup installed packages to have no duplicates.

@eugene-manuilov
Copy link
Collaborator

eugene-manuilov commented Oct 25, 2024

Plus we can probably move PUPPETEER_SKIP_CHROMIUM_DOWNLOAD from RUN to a separate ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=....

@eugene-manuilov
Copy link
Collaborator

@benbowler are all those lib* packages that you added in the dockerfile file really needed? Or it was copy/pasted from somewhere?

@benbowler
Copy link
Collaborator

@benbowler are all those lib* packages that you added in the dockerfile file really needed? Or it was copy/pasted from somewhere?

@eugene-manuilov they are from the puppeteer documentation linked in the code comment:

In gitlab-ci.yml we need to install some packages to make it possible to launch headless Chrome in your docker env.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants