-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix VRT failures in CI #9559
base: develop
Are you sure you want to change the base?
Fix VRT failures in CI #9559
Conversation
…isolate cause browser process not found issue.
Co-authored-by: Tom Rees-Herdman <[email protected]>
|
||
RUN apk upgrade --no-cache --available && \ | ||
PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true npm i -g backstopjs@${BACKSTOPJS_VERSION} && \ | ||
RUN apt-get update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Run
commands must be combined into one.
|
||
ARG BACKSTOPJS_VERSION=6.1.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Group ARG
s together:
ARG ...
ARG ...
ENV ...
|
||
ARG BACKSTOPJS_VERSION=6.1.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is the newer version of backstopjs - 6.3.2
. We should probably upgrade it as well, shouldn't we?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes, sorry, I missed that 👍🏻
Also, there are two |
Plus we can probably move |
@benbowler are all those |
@eugene-manuilov they are from the puppeteer documentation linked in the code comment:
|
Summary
Addresses issue:
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist