Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACR Dashboard Subtle Notification #9612

Open
wants to merge 23 commits into
base: develop
Choose a base branch
from

Conversation

benbowler
Copy link
Collaborator

Summary

Addresses issue:

Relevant technical choices

WIP, handing over while I'm on vacation. Outstanding work is unchecked in the issue and includes the render logic and tests. The banner components, actions, copy, style and stories are done here.

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@benbowler benbowler force-pushed the enhancement/9371-acr-dashboard-banner branch from f89893b to e457584 Compare November 5, 2024 09:13
@benbowler benbowler changed the base branch from develop to enhancement/9379-detected-lost-events-resolver November 5, 2024 09:13
Base automatically changed from enhancement/9379-detected-lost-events-resolver to develop November 5, 2024 12:49
@zutigrm zutigrm marked this pull request as ready for review November 7, 2024 11:21
Copy link

github-actions bot commented Nov 7, 2024

Build files for 32cf10d are ready:

Copy link

github-actions bot commented Nov 7, 2024

Size Change: +3.92 kB (+0.21%)

Total Size: 1.88 MB

Filename Size Change
./dist/assets/css/googlesitekit-admin-css-********************.min.css 60 kB +114 B (+0.19%)
./dist/assets/js/35-********************.js 935 B -1 B (-0.11%)
./dist/assets/js/googlesitekit-activation-********************.js 24.1 kB +71 B (+0.3%)
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 55 kB +90 B (+0.16%)
./dist/assets/js/googlesitekit-adminbar-********************.js 34.7 kB +60 B (+0.17%)
./dist/assets/js/googlesitekit-api-********************.js 10.2 kB +67 B (+0.66%)
./dist/assets/js/googlesitekit-components-gm2-********************.js 6.17 kB -10 B (-0.16%)
./dist/assets/js/googlesitekit-components-gm3-********************.js 10.1 kB -2 B (-0.02%)
./dist/assets/js/googlesitekit-datastore-site-********************.js 20.6 kB +70 B (+0.34%)
./dist/assets/js/googlesitekit-datastore-ui-********************.js 10.1 kB +72 B (+0.72%)
./dist/assets/js/googlesitekit-datastore-user-********************.js 27.4 kB +187 B (+0.69%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 81.6 kB +74 B (+0.09%)
./dist/assets/js/googlesitekit-main-dashboard-********************.js 160 kB +73 B (+0.05%)
./dist/assets/js/googlesitekit-modules-********************.js 22.2 kB +68 B (+0.31%)
./dist/assets/js/googlesitekit-modules-ads-********************.js 33.4 kB +57 B (+0.17%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js 117 kB +81 B (+0.07%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 184 kB +164 B (+0.09%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 22.8 kB +30 B (+0.13%)
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 41 kB +73 B (+0.18%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js 64.9 kB +67 B (+0.1%)
./dist/assets/js/googlesitekit-modules-sign-in-with-google-********************.js 24.4 kB +59 B (+0.24%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 32.3 kB +69 B (+0.21%)
./dist/assets/js/googlesitekit-notifications-********************.js 22.9 kB +89 B (+0.39%)
./dist/assets/js/googlesitekit-polyfills-********************.js 377 B -1 B (-0.26%)
./dist/assets/js/googlesitekit-settings-********************.js 123 kB +70 B (+0.06%)
./dist/assets/js/googlesitekit-splash-********************.js 69.1 kB +90 B (+0.13%)
./dist/assets/js/googlesitekit-user-input-********************.js 44 kB +416 B (+0.95%)
./dist/assets/js/googlesitekit-vendor-********************.js 322 kB +11 B (0%)
./dist/assets/js/googlesitekit-widgets-********************.js 97.8 kB +1.67 kB (+1.74%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 62.6 kB +37 B (+0.06%)
./dist/assets/js/runtime-********************.js 1.4 kB -2 B (-0.14%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.8 kB
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 846 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 8.2 kB
./dist/assets/js/32-********************.js 2.76 kB
./dist/assets/js/33-********************.js 2.25 kB
./dist/assets/js/34-********************.js 3.64 kB
./dist/assets/js/36-********************.js 893 B
./dist/assets/js/37-********************.js 1.61 kB
./dist/assets/js/38-********************.js 1.57 kB
./dist/assets/js/39-********************.js 1.61 kB
./dist/assets/js/40-********************.js 1.59 kB
./dist/assets/js/41-********************.js 1.83 kB
./dist/assets/js/42-********************.js 3.11 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 901 B
./dist/assets/js/googlesitekit-consent-mode-********************.js 25.6 kB
./dist/assets/js/googlesitekit-data-********************.js 2.37 kB
./dist/assets/js/googlesitekit-datastore-forms-********************.js 8.97 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.08 kB
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js 646 B
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js 624 B
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js 630 B
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js 712 B
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js 675 B
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js 634 B
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js 657 B
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js 633 B
./dist/assets/js/googlesitekit-i18n-********************.js 3.93 kB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants